From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: autoload cl-defstruct constructor? Date: Fri, 06 Sep 2019 15:25:29 -0700 Message-ID: <86a7bh83l2.fsf@stephe-leake.org> References: <86k1anriz5.fsf@stephe-leake.org> <86ef0u8geu.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="189187"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 07 00:26:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i6Mgr-000n2F-MK for ged-emacs-devel@m.gmane.org; Sat, 07 Sep 2019 00:26:50 +0200 Original-Received: from localhost ([::1]:60652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6Mgq-00008Y-K9 for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2019 18:26:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52249) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6Mfo-0008VR-Eo for emacs-devel@gnu.org; Fri, 06 Sep 2019 18:25:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i6Mfk-0001PU-2y for emacs-devel@gnu.org; Fri, 06 Sep 2019 18:25:43 -0400 Original-Received: from gateway33.websitewelcome.com ([192.185.146.68]:14123) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i6Mfg-0001LD-9a for emacs-devel@gnu.org; Fri, 06 Sep 2019 18:25:40 -0400 Original-Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 6853C55E65 for ; Fri, 6 Sep 2019 17:25:34 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 6MfeiNG5PiQer6Mfeiezmm; Fri, 06 Sep 2019 17:25:34 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=O4Lqa8TMwJd8qBkBieR3yci9TyqX5oG4j285dxrCii4=; b=IVNEqznQaEKQyLq7LRxWK/vys CzOxIcFDIGxlxnNlqEn/Fmxp5iYzKGE2rJNsQKoJkXnE5tCu8+TBgKAfRNFMvr+VC90ptHA9zTjYE gaAkGcpt/5osciuSai69FLXXx8gpt5u0fmPYPgWfnnyTXPNZMY+zEjxTDcg0ZepaXc02+JSG6FR8u TqatKCq/9w9JZsr6rg/p4jUhzYLZwHKjYYZ6rpi8hTSkTVIkamNNLUhqM/eWtI8N7pHByaHIi3XSe yX5AQPayT8ww8A5r2tx1cW2/bfD5TmZ6GgH6clBDxPrSzfvFzsUOUW4y2ayiKM6ofqAMUdkOJ1e7f 2PZ9FS3ZQ==; Original-Received: from [76.77.182.20] (port=49346 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i6Mfd-001Sgs-Nu for emacs-devel@gnu.org; Fri, 06 Sep 2019 16:25:33 -0600 In-Reply-To: (Stefan Monnier's message of "Fri, 06 Sep 2019 08:47:49 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1i6Mfd-001Sgs-Nu X-Source-Sender: (Takver4) [76.77.182.20]:49346 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.185.146.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239908 Archived-At: Stefan Monnier writes: >> If I add an autoload cookie to a cl-defstruct, running >> update-directory-autoloads on the above gives: >> >> --- >> >> ;;; Generated autoloads from gnat-core.el >> >> (cl-defstruct gnat-compiler "\ >> Used with wisi-compiler-* generic functions." gpr-file run-buffer-name >> project-path target runtime gnat-stub-opts gnat-stub-cargs) > > Oh, right, because when the autoloads are generated `cl-defstruct` is > not defined at all. If you run update-directory-autoloads from within > a running Emacs where cl-lib is loaded, it will give you a result that's > much closer to what you want. Hmm. To build autoloads.el for ada-mode in my development tree, I run: emacs -Q -batch --eval "(progn (require 'autoload)(require 'cl-lib)(setq generated-autoload-file (expand-file-name \"../autoloads.el\"))(update-directory-autoloads \"../\"))" I just added the (require 'cl-lib), but I still get the same result for a cl-defstruct: --- autoloads.el ;;; Generated autoloads from gnat-core.el (cl-defstruct gnat-compiler "\ Used with wisi-compiler-* generic functions." gpr-file run-buffer-name project-path target runtime gnat-stub-opts gnat-stub-cargs) (autoload 'create-gnat-compiler "gnat-core" "\ --- What am I missing? We'll need to ensure package.el does the same when it generates autoloads. Or is that done on the elpa server? > Making cl-defstruct into an autoloaded macro would solve this part of > the problem. I guess that means adding a special case in make-autoload? -- -- Stephe