From: Paul Eggert <eggert@cs.ucla.edu>
To: Vibhav Pant <vibhavp@gmail.com>,
Philipp Stephani <p.stephani2@gmail.com>,
emacs-devel@gnu.org
Subject: Re: [PATCH] Use get_key_arg to parse keyword arguments in json_parse_object_type
Date: Tue, 26 Dec 2017 11:11:12 -0800 [thread overview]
Message-ID: <86a708a7-1b70-09e1-8d24-808d23a07e6b@cs.ucla.edu> (raw)
In-Reply-To: <m2y3lpnx30.fsf@newartisans.com>
John Wiegley wrote:
> I approve of the patch, Vibhav. I'm suprised we don't have a SAFE_CALLOC
> macro, though, to avoid having to use memset immediately after.
I guess Vibhav's future patches will make this issue moot, as the change doesn't
make sense by itself; it merely substitutes a less-efficient implementation for
a more-efficient one. Perhaps Vibhav's future changes will pass the argument
without memsetting it, for example.
It would be helpful to know what the future changes are, as it's hard to tell
whether the proposed patch is a good idea without seeing it in the context of
the future patches.
prev parent reply other threads:[~2017-12-26 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 6:39 [PATCH] Use get_key_arg to parse keyword arguments in json_parse_object_type Vibhav Pant
2017-12-22 13:32 ` Vibhav Pant
2017-12-26 18:49 ` John Wiegley
2017-12-26 19:11 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a708a7-1b70-09e1-8d24-808d23a07e6b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.