From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52491: 28.0.90; Regression in window deletion with minibuffer Date: Sun, 19 Dec 2021 20:25:14 +0200 Organization: LINKOV.NET Message-ID: <86a6gwe9kl.fsf@mail.linkov.net> References: <865yrqsxmu.fsf@mail.linkov.net> <865yro7csh.fsf@mail.linkov.net> <83h7b8fngd.fsf@gnu.org> <86v8zo4bma.fsf@mail.linkov.net> <83fsqsfh8i.fsf@gnu.org> <86tuf73aen.fsf@mail.linkov.net> <83h7b7e8t2.fsf@gnu.org> <4318fa2c-0127-4a14-f65e-399b5c097028@gmx.at> <86sfupu8xi.fsf@mail.linkov.net> <9c2cbe85-b1a0-f147-69c8-0f26ab2e7c4d@gmx.at> <86wnk0frfj.fsf@mail.linkov.net> <0a55b1f4-dd66-62ed-591a-75438033e357@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13538"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52491@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 19 19:27:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mz0u2-0003Kj-36 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 19:27:22 +0100 Original-Received: from localhost ([::1]:47266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mz0tz-00064c-V4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 13:27:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mz0ti-00062s-II for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 13:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mz0ti-00070u-9i for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 13:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mz0ti-0002dH-5J for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 13:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Dec 2021 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52491 X-GNU-PR-Package: emacs Original-Received: via spool by 52491-submit@debbugs.gnu.org id=B52491.163993836310050 (code B ref 52491); Sun, 19 Dec 2021 18:27:02 +0000 Original-Received: (at 52491) by debbugs.gnu.org; 19 Dec 2021 18:26:03 +0000 Original-Received: from localhost ([127.0.0.1]:48089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz0sl-0002c2-EZ for submit@debbugs.gnu.org; Sun, 19 Dec 2021 13:26:03 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:44423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz0sj-0002bX-Ge for 52491@debbugs.gnu.org; Sun, 19 Dec 2021 13:26:01 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 445CDC0002; Sun, 19 Dec 2021 18:25:53 +0000 (UTC) In-Reply-To: <0a55b1f4-dd66-62ed-591a-75438033e357@gmx.at> (martin rudalics's message of "Sun, 19 Dec 2021 19:16:26 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222736 Archived-At: >> I checked that the value is the same in 27 and 28. > > Not here. If with > > (setq enable-recursive-minibuffers t) > > followed by M-x, TAB, kp-prior and > > M-: (window-parameter nil 'quit-restore) > > Emacs 27.2.50 gets me > > (window window # #) > > while Emacs 28.0.90 gets me nil. I get nil too, but I don't believe this value. Maybe because of some strange window interactions, the displayed value is wrong. When I tried to print the real value with 'message' in the *Messages* value, it was the same as in 27.2.90. >> But while comparing >> quit-restore-window in 27 and 28 indeed there are many differences. >> >> In 27, quit-restore-window calls window--delete, and then later does >> `(select-window (nth 2 quit-restore))'. >> >> But in 28, for the dedicated *Completions* window it calls >> window--delete, but doesn't call `(select-window (nth 2 quit-restore))' >> afterwards, that is another `cond' branch. > > All these are easily explained by my observation above. And, with Emacs > 27 the *Completions* window is softly dedicated to its buffer here while > with Emacs 28 it is not dedicated to its buffer. Please recheck. I checked that in 28 in 'quit-restore-window', only these 2 lines are used: ((and dedicated (not (eq dedicated 'side)) (window--delete window 'dedicated (eq bury-or-kill 'kill)))) but these lines are not used in 28: (when (window-live-p (nth 2 quit-restore)) (select-window (nth 2 quit-restore))) But in 27 they correctly selected the minibuffer window.