From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 52491@debbugs.gnu.org
Subject: bug#52491: 28.0.90; Regression in window deletion with minibuffer
Date: Sun, 19 Dec 2021 20:25:14 +0200 [thread overview]
Message-ID: <86a6gwe9kl.fsf@mail.linkov.net> (raw)
In-Reply-To: <0a55b1f4-dd66-62ed-591a-75438033e357@gmx.at> (martin rudalics's message of "Sun, 19 Dec 2021 19:16:26 +0100")
>> I checked that the value is the same in 27 and 28.
>
> Not here. If with
>
> (setq enable-recursive-minibuffers t)
>
> followed by M-x, TAB, kp-prior and
>
> M-: (window-parameter nil 'quit-restore)
>
> Emacs 27.2.50 gets me
>
> (window window #<window 4 on *Minibuf-1*> #<buffer *Completions*>)
>
> while Emacs 28.0.90 gets me nil.
I get nil too, but I don't believe this value.
Maybe because of some strange window interactions,
the displayed value is wrong. When I tried to print
the real value with 'message' in the *Messages* value,
it was the same as in 27.2.90.
>> But while comparing
>> quit-restore-window in 27 and 28 indeed there are many differences.
>>
>> In 27, quit-restore-window calls window--delete, and then later does
>> `(select-window (nth 2 quit-restore))'.
>>
>> But in 28, for the dedicated *Completions* window it calls
>> window--delete, but doesn't call `(select-window (nth 2 quit-restore))'
>> afterwards, that is another `cond' branch.
>
> All these are easily explained by my observation above. And, with Emacs
> 27 the *Completions* window is softly dedicated to its buffer here while
> with Emacs 28 it is not dedicated to its buffer. Please recheck.
I checked that in 28 in 'quit-restore-window', only these 2 lines are used:
((and dedicated (not (eq dedicated 'side))
(window--delete window 'dedicated (eq bury-or-kill 'kill))))
but these lines are not used in 28:
(when (window-live-p (nth 2 quit-restore))
(select-window (nth 2 quit-restore)))
But in 27 they correctly selected the minibuffer window.
next prev parent reply other threads:[~2021-12-19 18:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 21:08 bug#52491: 28.0.90; Regression in window deletion with minibuffer Juri Linkov
2021-12-16 17:28 ` Juri Linkov
2021-12-16 17:50 ` Eli Zaretskii
2021-12-16 19:02 ` Juri Linkov
2021-12-16 20:05 ` Eli Zaretskii
2021-12-17 8:25 ` Juri Linkov
2021-12-17 12:04 ` Eli Zaretskii
2021-12-18 9:05 ` martin rudalics
2021-12-18 17:20 ` Juri Linkov
2021-12-19 10:14 ` martin rudalics
2021-12-19 17:14 ` Juri Linkov
2021-12-19 18:16 ` martin rudalics
2021-12-19 18:25 ` Juri Linkov [this message]
2021-12-20 9:18 ` martin rudalics
2021-12-20 17:29 ` Eli Zaretskii
2021-12-20 18:08 ` martin rudalics
2021-12-20 18:18 ` Eli Zaretskii
2021-12-21 8:05 ` Juri Linkov
2021-12-21 10:33 ` martin rudalics
2021-12-21 19:13 ` Juri Linkov
2021-12-22 9:23 ` martin rudalics
2021-12-21 8:08 ` Juri Linkov
2021-12-21 10:34 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a6gwe9kl.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=52491@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.