bug#58970: 29.0.50; Broken overlays order

bug#58970: 29.0.50; Broken overlays order

[Juri Linkov]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

After the merge of the noverlay branch, the order of overlays is reversed
in the return value of 'overlays-in'.  This broke at least flyspell.el
where flyspell-auto-correct-previous-word now changes an unexpected word
at the top of the buffer instead of fixing the last typed word.
This has a disastrous effect since these changes go unnoticed at the
beginning of the file.

This patch fixes at least flyspell.el, but no idea what other packages
are broken in the same way:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: overlays-in.patch --]
[-- Type: text/x-diff, Size: 628 bytes --]

diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
index a66b72cfd06..11039f29630 100644
--- a/lisp/textmodes/flyspell.el
+++ b/lisp/textmodes/flyspell.el
@@ -2131,7 +2131,9 @@ flyspell-auto-correct-previous-word
 	  ;; only reset if a new overlay exists
 	  (setq flyspell-auto-correct-previous-pos nil)
 
-	  (let ((overlay-list (overlays-in (point-min) position))
+	  (let ((overlay-list (seq-sort-by
+                               #'overlay-start #'>
+                               (overlays-in (point-min) position)))
 		(new-overlay 'dummy-value))
 
 	    ;; search for previous (new) flyspell overlay

bug#58970: 29.0.50; Broken overlays order

[Juri Linkov]

close 58970 29.0.50
stop

> After the merge of the noverlay branch, the order of overlays is reversed
> in the return value of 'overlays-in'.  This broke at least flyspell.el
> where flyspell-auto-correct-previous-word now changes an unexpected word
> at the top of the buffer instead of fixing the last typed word.
> This has a disastrous effect since these changes go unnoticed at the
> beginning of the file.
>
> This patch fixes at least flyspell.el, but no idea what other packages
> are broken in the same way:

Now fixed overlays in flyspell.el, and closed.