From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#64575: 29.0.92; Help buffers are unnecessarily under Outline mode Date: Wed, 12 Jul 2023 09:35:03 +0300 Organization: LINKOV.NET Message-ID: <86a5w17hn4.fsf@mail.linkov.net> References: <83a5w26yum.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39069"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 64575@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 12 08:49:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJTf4-0009xm-GB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jul 2023 08:49:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJTeq-0001uA-W6; Wed, 12 Jul 2023 02:49:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJTep-0001ts-5u for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 02:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJTeo-0005tB-Dx for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 02:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJTeo-00036H-78 for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 02:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jul 2023 06:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64575 X-GNU-PR-Package: emacs Original-Received: via spool by 64575-submit@debbugs.gnu.org id=B64575.168914449311741 (code B ref 64575); Wed, 12 Jul 2023 06:49:02 +0000 Original-Received: (at 64575) by debbugs.gnu.org; 12 Jul 2023 06:48:13 +0000 Original-Received: from localhost ([127.0.0.1]:51583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJTe1-00033H-Ha for submit@debbugs.gnu.org; Wed, 12 Jul 2023 02:48:13 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJTdz-00032P-Iv for 64575@debbugs.gnu.org; Wed, 12 Jul 2023 02:48:12 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id DA91540005; Wed, 12 Jul 2023 06:48:04 +0000 (UTC) In-Reply-To: <83a5w26yum.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jul 2023 22:18:41 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264953 Archived-At: > The *Help* buffer is still under Outline minor mode, although it now > makes no sense, since there are no heading lines in the buffer. But it has no adverse effect. OTOH, when some Help command will insert a heading line, then it will be handled automatically. For example, 'C-h m' (describe-mode) could take advantage of outline-minor-mode with heading lines for every displayed minor mode. > The actual functions you use in "C-h f" don't matter; the point is > that the Outline minor mode, once set by "C-h b", stays turned on in > the *Help* buffers, instead of being reset when not needed. If you still think it should be disabled everywhere outside of 'C-h b', this could be fixed by such patch: diff --git a/lisp/help-mode.el b/lisp/help-mode.el index bf64d032b65..baf924ac8b4 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -498,6 +498,8 @@ help-setup-xref because we want to record the \"previous\" position of point so we can restore it properly when going back." (with-current-buffer (help-buffer) + (when (bound-and-true-p outline-minor-mode) + (outline-minor-mode -1)) (when help-xref-stack-item (push (cons (point) help-xref-stack-item) help-xref-stack) (setq help-xref-forward-stack nil))