From: Arash Esbati <arash@gnu.org>
To: 64717@debbugs.gnu.org
Cc: eric@ericabrahamsen.net
Subject: bug#64717: [PATCH] Silence the compiler in vcard-parse.el from ELPA
Date: Tue, 18 Jul 2023 22:48:10 +0200 [thread overview]
Message-ID: <86a5vt6j5h.fsf@gnu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
X-Debbugs-CC: eric@ericabrahamsen.net
Hi all,
this is a tiny patch against vcard-parse.el in order to pacify the
warnings about
‘point-at-bol’ is an obsolete function ...
‘point-at-eol’ is an obsolete function ...
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-vcard-parse.el-vcard-parse-buffer-Pacify-the-compile.patch --]
[-- Type: text/x-patch, Size: 1098 bytes --]
From f0bf7e52772064d1ccfcfe84798a658220483ec6 Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Tue, 18 Jul 2023 22:31:50 +0200
Subject: [PATCH] ; * vcard-parse.el (vcard-parse-buffer): Pacify the compiler.
---
vcard-parse.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/vcard-parse.el b/vcard-parse.el
index 571faa1c6e..e43ceed8be 100644
--- a/vcard-parse.el
+++ b/vcard-parse.el
@@ -1,6 +1,6 @@
;;; vcard-parse.el --- Library for parsing vCards -*- lexical-binding: t; -*-
-;; Copyright (C) 2019-2022 Free Software Foundation, Inc.
+;; Copyright (C) 2019-2023 Free Software Foundation, Inc.
;; Author: Eric Abrahamsen <eric@ericabrahamsen.net>
;; Maintainer: Eric Abrahamsen <eric@ericabrahamsen.net>
@@ -221,8 +221,8 @@ Returns a list of contact objects."
'(vcard) :error
"Parsing failed with:\n %s"
(buffer-substring-no-properties
- (point-at-bol)
- (point-at-eol))))))
+ (line-beginning-position)
+ (line-end-position))))))
(push card out)))
(nreverse out)))
--
2.41.0
[-- Attachment #3: Type: text/plain, Size: 473 bytes --]
And while we're at: There are also
In vcard-region-decode-base64:
vcard.el:516:29: Warning: avoid ‘lsh’; use ‘ash’ instead
vcard.el:518:27: Warning: avoid ‘lsh’; use ‘ash’ instead
vcard.el:518:51: Warning: avoid ‘lsh’; use ‘ash’ instead
vcard.el:530:32: Warning: avoid ‘lsh’; use ‘ash’ instead
Is `ash' a drop-in replacement? Maybe these can be fixed as well.
This is with Emacs 30.0.50 (f624b283bf).
Best, Arash
next reply other threads:[~2023-07-18 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 20:48 Arash Esbati [this message]
2023-07-18 21:59 ` bug#64717: [PATCH] Silence the compiler in vcard-parse.el from ELPA Eric Abrahamsen
2023-07-19 14:59 ` Arash Esbati
2023-08-23 23:45 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5vt6j5h.fsf@gnu.org \
--to=arash@gnu.org \
--cc=64717@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.