From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Updating *Completions* as you type Date: Tue, 17 Oct 2023 21:20:39 +0300 Organization: LINKOV.NET Message-ID: <86a5shyw48.fsf@mail.linkov.net> References: <87bkd3z9bi.fsf@catern.com> <86cyxjyr1y.fsf@mail.linkov.net> <86r0lxm7um.fsf@mail.linkov.net> <87o7gxwaxe.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32253"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: sbaugh@catern.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 17 20:47:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qsp6j-0008FC-4j for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Oct 2023 20:47:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsp4t-0006L0-8s; Tue, 17 Oct 2023 14:46:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsp4Z-0006BO-LX for emacs-devel@gnu.org; Tue, 17 Oct 2023 14:45:44 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsp4U-00059l-2g for emacs-devel@gnu.org; Tue, 17 Oct 2023 14:45:43 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 5F87940003; Tue, 17 Oct 2023 18:45:25 +0000 (UTC) In-Reply-To: <87o7gxwaxe.fsf@catern.com> (sbaugh@catern.com's message of "Tue, 17 Oct 2023 11:01:01 -0400") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311545 Archived-At: > What if the concept of "current selected completion" was unified with > "the default completion"? This could be a nice, general UI. > > Specifically, with switch-to-buffer and a default of init.el: > > - If init.el is present in *Completions*, start out with point on it. > This would be purely a display nicety, it wouldn't actually affect > anything yet. (This would be easy with my patch which I posted > elsewhere in this thread to preserve the location of point in > *Completions*) I think preselecting the default value in the middle of completions would make sense only when completions were sorted by the order of the list of default values (from M-n M-n ...). Then the first default value would be at the top of completions, and it would easier for users to navigate completions top-down. > - If and when the user invokes minibuffer-next-completion: > - The default changes to whatever the new selected completion is > - The prompt text "(default init.el)" changes permanently to literally > "(default selected completion)" Changing the prompt might interfere with such packages as minibuf-eldef.el and other cases of customized minibuffer-default-prompt-format. Also this might break commands that manually handle the default value for empty input. > - RET, as always, chooses the default if the minibuffer is empty; if the > user has done minibuffer-next-completion, the default is the selected > completion, so RET will choose that. > - M-RET (minibuffer-choose-completion) is replaced with a new command > which immediately chooses the default, whatever it is, ignoring the > current contents of the minibuffer What should RET do after the user navigated in *Completions* and switched back to the minibuffer. A different candidate is highlighted in *Completions*, while the default value remains unchanged. BTW, while looking at this case I found a problem with your first patch: after navigating in *Completions* and switching back to the minibuffer point is reset to the beginning of the *Completions* buffer. > - C-u M-RET inserts the default in the the minibuffer, without exiting > (matching the behavior of C-u minibuffer-choose-completion) Usually the default is inserted by M-n. > I think this has some nice benefits in reducing the number of concepts > people need to track. If the minibuffer is empty, they can just use > minibuffer-next-completion a few times followed by RET to select a > completion, no need to use M-RET. Plus, the new M-RET and C-u M-RET > would be useful even to users who don't use minibuffer-next-completion. It seems this is intended to solve the problem of a mismatch between the highlighted candidate and the contents of the minibuffer? Such problem exists, for example, in icomplete-mode where RET returns the contents of the minibuffer, so a special key 'C-j' is dedicated to select the highlighted candidate. For selecting a highlighted candidate from *Completions* such key is 'M-RET'. > I also think this would make it less painful to set > minibuffer-completion-auto-choose to nil, which matches > completion-in-region better and also works much better with > completions-auto-update. Sorry, I don't understand how this would make minibuffer-completion-auto-choose=nil less painful. Since there is no concept of the default value for completion-in-region, 'M-RET' is the only way to choose the highlighted candidate.