From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#68570: 29.1; recompile might not re-use project-compile's buffer Date: Sat, 27 Jan 2024 19:53:34 +0200 Organization: LINKOV.NET Message-ID: <86a5oqmzmp.fsf@mail.linkov.net> References: <920b0c20-c6ee-4b41-84ec-5adfa06c64a2@jbornemann.de> <320b09d1-2af4-4110-bdf3-94da122f3dd6@gutov.dev> <86il3m1zi7.fsf@mail.linkov.net> <60842df3-8a64-4bde-b6d6-f94b9a964a17@gutov.dev> <86fryp7ubp.fsf@mail.linkov.net> <871a3ea4-46d9-419e-a375-1d32968ccc88@jbornemann.de> <867ck0leif.fsf@mail.linkov.net> <0598898e-8e25-43b1-92c0-4596ad242ec8@gutov.dev> <86bk9b6vu4.fsf@mail.linkov.net> <86o7da1ws8.fsf@mail.linkov.net> <2a3f08b8-5334-41c6-8003-707424a8a0fe@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33989"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: =?UTF-8?Q?J=C3=B6rg?= Bornemann , 68570@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 27 19:07:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTn5E-0008fF-5x for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Jan 2024 19:07:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTn4z-0002Mk-5T; Sat, 27 Jan 2024 13:06:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTn4y-0002MS-04 for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 13:06:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTn4x-0003bQ-NN for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 13:06:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rTn54-0008FX-Rb for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 13:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jan 2024 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68570 X-GNU-PR-Package: emacs Original-Received: via spool by 68570-submit@debbugs.gnu.org id=B68570.170637877131640 (code B ref 68570); Sat, 27 Jan 2024 18:07:02 +0000 Original-Received: (at 68570) by debbugs.gnu.org; 27 Jan 2024 18:06:11 +0000 Original-Received: from localhost ([127.0.0.1]:55861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTn4E-0008EE-Rj for submit@debbugs.gnu.org; Sat, 27 Jan 2024 13:06:11 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTn4A-0008DZ-OK for 68570@debbugs.gnu.org; Sat, 27 Jan 2024 13:06:09 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 5253A40003; Sat, 27 Jan 2024 18:05:51 +0000 (UTC) In-Reply-To: <2a3f08b8-5334-41c6-8003-707424a8a0fe@gutov.dev> (Dmitry Gutov's message of "Fri, 26 Jan 2024 02:44:17 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279022 Archived-At: >> It's very useful to always create a unique buffer for every compilation: >> this allows keeping error messages from previous compilations. > > Hmm, but I suppose it can be a personal preference whether a "recompile" > should create a new buffer or not. > > Because it's also reasonable to expect that 'M-x compile' creates a new > buffer (e.g. project-prefixed and unique), but 'recompile', or > 'revert-buffer' - keep that buffer around and reuse it. When one wants to > keep the old contents, they could 'M-x compile' (or 'M-x project-compile') > instead. > > This might be my preference anyway, because OT1H old compilations are often > (but not always) handy to have around, OT2H I don't like to have too many > buffers, and the above distinction between 'compile' and 'recompile' would > be a tool to make that choice. A new option could be added indeed. But currently 'g' after 'compile' uses 'compilation-buffer-name-function' that can be configured to generate a new buffer. So it's expected that 'g' after 'project-compile' should do the same and use 'project-compilation-buffer-name-function', especially when it's configured to generate a new buffer. IOW, I think these two 'compile' and 'project-compile' should be in sync in regard to what 'recompile' does. >> I propose even to add such an option to the choice list in >> project-compilation-buffer-name-function, e.g.: >> (defcustom project-compilation-buffer-name-function nil >> :type '(choice (const :tag "Default" nil) >> (const :tag "Prefixed with project name" >> project-prefixed-buffer-name) >> (const :tag "Prefixed and unique with project name" >> project-prefixed-unique-buffer-name) >> (function :tag "Custom function"))) > > Sounds good. There is also a proposal to add the same option to 'compilation-buffer-name-function' in bug#68697. >> The previous patch would be needed as well since currently >> there is no way to allow unique project compilation buffers. > > The one in 0a07603ae8d? Actually I meant https://debbugs.gnu.org/68570#23