From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v3 0/1] Support styled underlines on tty Emacs frames Date: Sun, 28 Jan 2024 14:05:32 +0200 Message-ID: <86a5op64tv.fsf@gnu.org> References: <20230422102146.93003-1-mohkale@kisara.moe> <86le89itke.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6845"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62994@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 28 13:06:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rU3vY-0001Yl-PY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jan 2024 13:06:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rU3vB-0007Sb-6y; Sun, 28 Jan 2024 07:05:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rU3v9-0007RG-3Q for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 07:05:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rU3v8-00036X-Qr for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 07:05:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rU3vG-0008J0-69 for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 07:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jan 2024 12:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.170644355531911 (code B ref 62994); Sun, 28 Jan 2024 12:06:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 28 Jan 2024 12:05:55 +0000 Original-Received: from localhost ([127.0.0.1]:56778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rU3v8-0008Id-TE for submit@debbugs.gnu.org; Sun, 28 Jan 2024 07:05:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rU3v5-0008IK-9w for 62994@debbugs.gnu.org; Sun, 28 Jan 2024 07:05:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rU3us-0002zm-2Y; Sun, 28 Jan 2024 07:05:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3PwMjgVb65T3npL1jp4FvcPpqs5yZMTMhB+0sZa5Xlc=; b=qPWF6ST0/0Qm UCyfWLzHTb48STM2ek4S5BcRCeaxqGjgEjur1tanNdr2RSWa1Qiw4S3o6Vb05PfvOcPWpnoAPpuyP HJlvMUk3JmkerVg96JoDOwR/gl5XFES0vRhs1aZ0UW63xfK3uyotaDRBSErZFo/HEAvb6EjjWyoqv u/Lz5U5t3AnhSt2ixWHlyYgkV8t5eDMdi2afKsorNJb3xMBUVEN4D3n27GMP/NUNbMYx4gsAOVXZ6 8un5bIfcT/2u9vfg8v9xbOzwRRxkDMAJOn0p7dxykzfc+ipvfBsHfZOxk9BrteYS7n6oZz2Zzx0P0 dxdotO+CPy5UiqfNiZTk+A==; In-Reply-To: <86le89itke.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 28 Jan 2024 12:30:25 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279083 Archived-At: > From: Mohsin Kaleem > Date: Sun, 28 Jan 2024 12:30:25 +0100 > > mohkale@kisara.moe writes: > > My copyright situation should be solved now. I was waiting on something > else from my work but would rather not put this off any longer. That's good to know, thanks. > I've > figured out how to do the correct resolution for color. Only thing > that's confusing me a little is that in src/xfaces:6466 for > map_tty_color it looks like we change the color in the face spec itself > only on MSDOS frames. What are the ramifications of this? Is this logic > we want to keep going forward? The MSDOS frames are different from other TTY frames in that we can know the default colors used by the MSDOS terminals. That's why MSDOS needs a special code there. And yes, we want to keep this logic, for MSDOS only. > For reference I don't this should be done for the underline spec > because unlike foreground and background it can be a string or a > plist containing the color value and we would not want to update it > in place. The MSDOS terminal doesn't support underline, so no worries here.