From: Juri Linkov <juri@linkov.net>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 68881@debbugs.gnu.org
Subject: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode'
Date: Wed, 07 Feb 2024 19:37:11 +0200 [thread overview]
Message-ID: <86a5ocgp74.fsf@mail.linkov.net> (raw)
In-Reply-To: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> (Jim Porter's message of "Thu, 1 Feb 2024 15:51:57 -0800")
> I'd like to add support for 'outline-minor-mode' in Eshell. However,
> Eshell's use of field properties confuses outline.el. Attached is a WIP
> patch + demo code for Eshell that should resolve this.
>
> The main issue was that outline.el uses 'line-beginning-position' and
> friends, which respects field boundaries, but I think we want to avoid that
> for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead,
> but my understanding is that 'line-beginning-position' respects display
> directionality (which we probably want), but 'pos-bol' doesn't.
I'm not aware of any cases that would require restricting
outlines to field boundaries.
> You can try things out here by starting Eshell and activating
> 'outline-minor-mode'. You can also see the problems by applying only the
> Eshell part of the patch.
Thanks. I tried and confirm that your outline.el patch fixes the issue.
> Any thoughts? Is this the right way to go about this? (Note: I think the
> Eshell side of things will take more work, which I'll address in a later
> bug. However, this should be enough to show off the problems on the
> outline.el side.)
There is also one occurrence of 'line-end-position' in outline.el.
Should it have 'inhibit-field-text-motion' as well?
next prev parent reply other threads:[~2024-02-07 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 23:51 bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Jim Porter
2024-02-07 17:37 ` Juri Linkov [this message]
2024-02-10 18:22 ` Jim Porter
2024-02-10 19:23 ` Eli Zaretskii
2024-02-10 21:14 ` Jim Porter
2024-02-11 6:07 ` Eli Zaretskii
2024-02-11 7:08 ` Jim Porter
2024-02-11 17:40 ` Juri Linkov
2024-02-11 18:19 ` Jim Porter
2024-02-12 18:25 ` Juri Linkov
2024-02-13 4:03 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5ocgp74.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=68881@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.