From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#68958: [PATCH] Support bookmarking Xref results buffers Date: Sun, 11 Feb 2024 19:37:59 +0200 Organization: LINKOV.NET Message-ID: <86a5o6yk94.fsf@mail.linkov.net> References: <868r3wi57v.fsf@mail.linkov.net> <53a9fafc-7b2a-485e-b6c1-df3f372b60e2@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9694"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eshel Yaron , 68958@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 11 18:56:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZE3q-0002OA-NU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Feb 2024 18:56:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZE3R-0007ZE-R1; Sun, 11 Feb 2024 12:55:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZE3P-0007YG-Lo for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 12:55:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZE3P-00023Z-9s for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 12:55:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZE3e-0001wN-IJ for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 12:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Feb 2024 17:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68958 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68958-submit@debbugs.gnu.org id=B68958.17076741207337 (code B ref 68958); Sun, 11 Feb 2024 17:56:02 +0000 Original-Received: (at 68958) by debbugs.gnu.org; 11 Feb 2024 17:55:20 +0000 Original-Received: from localhost ([127.0.0.1]:35533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZE2y-0001uC-6o for submit@debbugs.gnu.org; Sun, 11 Feb 2024 12:55:20 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:52823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZDzG-0001ib-Mo for 68958@debbugs.gnu.org; Sun, 11 Feb 2024 12:51:31 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id F287120005; Sun, 11 Feb 2024 17:51:06 +0000 (UTC) In-Reply-To: <53a9fafc-7b2a-485e-b6c1-df3f372b60e2@gutov.dev> (Dmitry Gutov's message of "Sun, 11 Feb 2024 05:21:25 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279862 Archived-At: >> I once tried to use 'revert-buffer-function' to restore >> xref buffers from the desktop, but abandoned the idea. >> Not because xref.el doesn't set 'revert-buffer-function'. >> But because it would take too much time to restore >> the desktop while it will rerun all saved xref buffers. >> OTOH, saving an xref bookmark makes more sense. >> And probably your patch will help to implement >> 'revert-buffer-function' for xref as well. > > I don't think bookmark would save the whole buffer contents. Would it? > Otherwise, re-running the search(es) seems inevitable. Indeed, saving the buffer contents of transient buffers either to the bookmark or to the desktop makes no sense. So re-running the command is inevitable. But then I can't imagine how would it be possible to move point to its saved location when initially a restored buffer is empty before re-running the command.