From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Sat, 24 Feb 2024 12:30:16 +0200 Message-ID: <86a5nqyx1j.fsf@gnu.org> References: <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org> <19265EA5-E6F3-446C-AD9B-763693CF0A48@gmail.com> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@gmail.com> <13877748-AFAB-4310-A0CA-104752C8BF2D@gmail.com> <5C9DFD74-B166-444E-BFDC-D022826098C8@gmail.com> <8F240949-B24F-4538-8ED1-7153F10AB5EC@gmail.com> <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@gmail.com> <86sf1nnslp.fsf@gnu.org> <886A589C-5139-4FC9-8B59-636A9D6DFBD4@gmail.com> <86frxnnjq1.fsf@gnu.org> <86r0h6m0rh.fsf@gnu.org> <2E0CDF51-5871-4F53-91B0-33115E30B1F2@gmail.com> <7768784D-876F-4E75-8BA6-4DAAA55803A3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36314"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68244@debbugs.gnu.org, gerd.moellmann@gmail.com, dmitry@gutov.dev, stefankangas@gmail.com, acorallo@gnu.org, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 24 11:31:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdpJ8-0009Fj-W9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Feb 2024 11:31:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdpIt-0000YK-Hm; Sat, 24 Feb 2024 05:30:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdpIl-0000XI-5l for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2024 05:30:45 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdpIk-000570-9u for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2024 05:30:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdpJ8-0004CR-8w for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2024 05:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Feb 2024 10:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs Original-Received: via spool by 68244-submit@debbugs.gnu.org id=B68244.170877066116059 (code B ref 68244); Sat, 24 Feb 2024 10:31:02 +0000 Original-Received: (at 68244) by debbugs.gnu.org; 24 Feb 2024 10:31:01 +0000 Original-Received: from localhost ([127.0.0.1]:46003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdpJ6-00049j-OE for submit@debbugs.gnu.org; Sat, 24 Feb 2024 05:31:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdpJ4-0003tv-Ql for 68244@debbugs.gnu.org; Sat, 24 Feb 2024 05:30:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdpIb-00051O-3t; Sat, 24 Feb 2024 05:30:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=PJvAfp4qV15ecE5NAyVtK2ScKsXKvU8GRc2wj7sOFRM=; b=Do/+rnpLVc0QrHIB8iUS DkcCLgR8Q7cjslj+LykSBmEIcrqs0C+uq2qbyXvV7TPXPEKWteKLm2yjMaMWSl9BQmayqbEsYjphu cmNvHQ60Aq1dxda0pFQTa5xKG76WSSnlaF7+slhWBPNu6vPttB4XxTDf/unwwWyzyXU7QxrJbgUQy vYmsiV6uYgqW4gphut0uP8BL2aMUle7jmBpZc9ML0rA+6bPQjzUxx6e7Kishhc+wSTKWw/GjfuJL0 tvEW9dC1QaDLZM5Ap4z7IQf9HDAVwcyx7NoeKJgG0G79fTRdqwfDHhbI/SeChzZREyKl26BVBR4oJ RGsU/2FwZRdrnQ==; In-Reply-To: <7768784D-876F-4E75-8BA6-4DAAA55803A3@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 24 Feb 2024 10:45:03 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280541 Archived-At: > From: Mattias Engdegård > Date: Sat, 24 Feb 2024 10:45:03 +0100 > Cc: gerd.moellmann@gmail.com, > dmitry@gutov.dev, > 68244@debbugs.gnu.org, > monnier@iro.umontreal.ca, > stefankangas@gmail.com > > 15b6d72599b9 on master: > > > +If you have code which creates obarrays as a simple Lisp vector: > > + > > + (make-vector N nil) > > + > > +and then calls 'intern' using such an obarray as second argument, this > > +will now signal a wrong-type-argument error; replace nil with zero to > > +make it work again. > > Thank you Eli, this might be useful, and you are absolutely right that we should help users fix their code. > > But this cannot have come from nowhere. Did anyone actually tried to create obarrays in this broken way? Yes, see Dmitry's message up-thread, which named the offending package. I've looked at it, and verified that it really does use this paradigm. > And if anyone did try to create an obarray in that incorrect way, better recommend using `obarray-make` which is more future-safe than an already obsolete form. I'm fine with adding to NEWS the text that suggests obarray-make, but the text I added has to stay, since the make-vector method evidently exists in the wild.