From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 69108-done@debbugs.gnu.org, Hi-Angel@yandex.ru
Subject: bug#69108: false-positive warning "variable ‘_’ not left unused" in if-let* and if-let
Date: Sun, 25 Feb 2024 09:42:07 +0200 [thread overview]
Message-ID: <86a5npxa5s.fsf@gnu.org> (raw)
In-Reply-To: <87a5npux4z.fsf@web.de> (message from Michael Heerdegen on Sun, 25 Feb 2024 02:54:04 +0100)
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: 69108@debbugs.gnu.org, Hi-Angel@yandex.ru
> Date: Sun, 25 Feb 2024 02:54:04 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > > [...] repeating a test. Is this what you prefer?
> >
> > Yes, I think so. And you could perhaps avoid repetition of
> > (cdr binding) by saving the result of (null (cdr binding)) in
> > a local variable.
>
> I went with a separate `cond' branch added instead, I think this is even
> simpler. Ok?
Yes, thanks.
> > > {My unsuccessful doc tweaks}
> >
> > [...] I'd prefer to separate it.
>
> Done. Feel free to tune it to your likes. Or send me an "ok", then
> I'll just commit this version.
I installed them both, thanks.
Closing the bug.
prev parent reply other threads:[~2024-02-25 7:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 21:21 bug#69108: false-positive warning "variable ‘_’ not left unused" in if-let* and if-let Konstantin Kharlamov
2024-02-14 1:01 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-17 0:28 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-17 8:04 ` Eli Zaretskii
2024-02-17 9:20 ` Konstantin Kharlamov
2024-02-17 11:45 ` Ihor Radchenko
2024-02-17 10:09 ` Konstantin Kharlamov
2024-02-19 12:37 ` Ihor Radchenko
2024-02-19 13:44 ` Konstantin Kharlamov
2024-02-17 21:46 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-17 22:02 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-18 6:53 ` Eli Zaretskii
2024-02-25 1:54 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 7:42 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5npxa5s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69108-done@debbugs.gnu.org \
--cc=Hi-Angel@yandex.ru \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.