From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67142: 29.1; with-sqlite-transaction commits on exception rather than rolling back Date: Mon, 11 Mar 2024 15:25:11 +0200 Message-ID: <86a5n4vr2g.fsf@gnu.org> References: <83pm09pz2n.fsf@gnu.org> <831qcoq0py.fsf@gnu.org> <87a5rc4vwy.fsf@gmail.com> <83leavmjnu.fsf@gnu.org> <87wmqjtnr3.fsf@neverwas.me> <87o7bl77sn.fsf@neverwas.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31014"; mail-complaints-to="usenet@ciao.gmane.io" Cc: visuweshm@gmail.com, mail@vasilij.de, 67142@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 11 14:26:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjfg1-0007rs-8a for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Mar 2024 14:26:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjffi-0004c2-SD; Mon, 11 Mar 2024 09:26:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjffh-0004bq-Sc for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 09:26:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjffg-0005aA-St for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 09:26:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjfgE-0000xS-MC for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 09:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Mar 2024 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67142 X-GNU-PR-Package: emacs Original-Received: via spool by 67142-submit@debbugs.gnu.org id=B67142.17101635683615 (code B ref 67142); Mon, 11 Mar 2024 13:27:02 +0000 Original-Received: (at 67142) by debbugs.gnu.org; 11 Mar 2024 13:26:08 +0000 Original-Received: from localhost ([127.0.0.1]:39244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjffL-0000wF-Ua for submit@debbugs.gnu.org; Mon, 11 Mar 2024 09:26:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjffK-0000vn-Vx for 67142@debbugs.gnu.org; Mon, 11 Mar 2024 09:26:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjfef-0005P4-ML; Mon, 11 Mar 2024 09:25:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hpsGF2SeeEEyZ/yDqNQdM7Qjfzz+sjVnNo84Zw/HGuY=; b=Bf8p0C+6zjpp S5fUGt7fbAeFjxJWWSI0L7c9cTFmCFBjK9RrR/ivNJYR4P3Zde0e7qRIMw4uEARC+FEJci0L3MOYH gisZBJjyvqk9tbWE36bIdMomWXZVypKNMuFXhYjKXFDw2cLHCTo56mB9OU109dGZbhUk+31PtBpno T0QHmr6mMz7RAD6jqg10Hyav7V+Rph4Gj2U3yQB3KHeLtN+I5Woavr+wWXOSc3Oq5YM7HGEocIRwL enx2j+/R5VFaHpCiTKJjV2Ic/Lzzy+cQtEJrK0tcb4yxDdFdAZKrrwlK2REVcUtvQP4FQdAxvR0Dq fyA1HySEIzdkSFnBWmllUQ==; In-Reply-To: <87o7bl77sn.fsf@neverwas.me> (jp@neverwas.me) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281472 Archived-At: > From: "J.P." > Cc: eliz@gnu.org, visuweshm@gmail.com, mail@vasilij.de > Date: Sun, 10 Mar 2024 20:43:04 -0700 > > "J.P." writes: > > > Not obvious on account of the indentation, but it seems the second > > > > (funcall ,func-var) > > > > snuck outside the `if' form with that fix, making body run twice if you > > have SQLite. > > I guess folks are too busy to get excited about fixing this. Here's a > patch in case that ever changes. Thanks. Thanks, installed on the emacs-29 branch.