From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MINI-PATCH: add how to turn auto-completion in test buffers off Date: Fri, 05 Apr 2024 15:41:59 +0300 Message-ID: <86a5m856co.fsf@gnu.org> References: <86y19t55hs.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Pedro Andres Aranda Gutierrez Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 05 14:42:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsiuH-0008xh-Hf for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Apr 2024 14:42:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsitc-0006st-Hz; Fri, 05 Apr 2024 08:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsita-0006sj-80 for emacs-devel@gnu.org; Fri, 05 Apr 2024 08:42:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsitZ-0003a7-Vs; Fri, 05 Apr 2024 08:42:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aCj8WW5x7O5wA+22Y420lVxnZXWagLYytvQMfXxzOKQ=; b=rYVjApmojhX2 E5lSyCz4vB58cs5q8ok77fB5LNpEHIgLdh9KnQCOoQbQIOCoDfdVXRGwZIgURvPRUlyvdZpS4nKNe cKDLqabRJ9+YaiEI4yERtMxYZevQtxVhZS5fhhWEzJoJXP7vbZEQzCPMYaewdexFCUnP+a5JeygVt ilekzUoMdUG+VxnX6GeZRiBoWojWJCLmuSo5eRhmh20/l9L4E4JbrzzXWys1bkzF/pzIDW+//hVOw AEog0KOUtN4tK5M7ExVqJMII17x4Tg49L5GeRwx4sFVO/oom9LuPGF2LErI9GIm6SdSxGmeptRfVo /xRhhidEIJsHsy+nGRFp7A==; In-Reply-To: (message from Pedro Andres Aranda Gutierrez on Fri, 5 Apr 2024 12:25:18 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317542 Archived-At: > From: Pedro Andres Aranda Gutierrez > Date: Fri, 5 Apr 2024 12:25:18 +0200 > Cc: emacs-devel@gnu.org > > so you mean something like the attached patch? Almost, see below. > diff --git a/doc/emacs/text.texi b/doc/emacs/text.texi > index cb347d59948..f039c42d46c 100644 > --- a/doc/emacs/text.texi > +++ b/doc/emacs/text.texi > @@ -954,6 +954,11 @@ Text Mode > Entering Text mode runs the mode hook @code{text-mode-hook} > (@pxref{Major Modes}). > > +@vindex text-mode-ispell-word-completion > + Entering Text mode also activates auto-complete hints. If you find > +that this is disturbing for you, set this variable to @code{nil} in > +your Emacs initialization code. This is using the wrong tone for describing the issue: it regards completion hints in Text Mode as a nuisance in most cases. If it were such a nuisance, we ought to make it off by default. Instead, the text should describe the completion hints feature from the POV of its being useful, and then say that the variable text-mode-ispell-word-completion controls it. Also, @vindex generates no text in the formatted manual, so you need to mention the variable in the text as well, otherwise "this variable" will allude to something the text doesn't mention. Finally, please leave two spaces between sentences, per our conventions. > --- a/lisp/textmodes/text-mode.el > +++ b/lisp/textmodes/text-mode.el > @@ -145,7 +145,10 @@ text-mode > You can thus get the full benefit of adaptive filling > (see the variable `adaptive-fill-mode'). > \\{text-mode-map} > -Turning on Text mode runs the normal hook `text-mode-hook'." > +Turning on Text mode runs the normal hook `text-mode-hook'. > +By default, `text-mode-hook' will enable completion at point with > +candidates supplied by `ispell'. You can turn this off by > +setting `text-mode-ispell-word-completion' to `nil'." This part is okay (modulo the 2 spaces between sentences issue). Thanks.