From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#69983: Use category for display-buffer-alist Date: Tue, 09 Apr 2024 09:30:31 +0300 Organization: LINKOV.NET Message-ID: <86a5m3jboy.fsf@mail.linkov.net> References: <86h6gv7e0z.fsf@mail.linkov.net> <3e7b8e64-0a5f-4888-a443-9c69a5fffd98@gmx.at> <86wmpdu0fa.fsf@mail.linkov.net> <86h6gf69jd.fsf@mail.linkov.net> <86sezyjpsn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23626"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 69983@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 09 08:43:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ru5Cg-00063g-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Apr 2024 08:43:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ru5C6-0005Z8-1H; Tue, 09 Apr 2024 02:42:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru5C4-0005YK-3P for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 02:42:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ru5C3-00008U-Iz for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 02:42:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ru5CA-0000bS-7R for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 02:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2024 06:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69983 X-GNU-PR-Package: emacs Original-Received: via spool by 69983-submit@debbugs.gnu.org id=B69983.17126449752294 (code B ref 69983); Tue, 09 Apr 2024 06:43:02 +0000 Original-Received: (at 69983) by debbugs.gnu.org; 9 Apr 2024 06:42:55 +0000 Original-Received: from localhost ([127.0.0.1]:48121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru5C2-0000at-E1 for submit@debbugs.gnu.org; Tue, 09 Apr 2024 02:42:55 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:51751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru5Bw-0000Zg-PG for 69983@debbugs.gnu.org; Tue, 09 Apr 2024 02:42:52 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id F2B621BF208; Tue, 9 Apr 2024 06:42:33 +0000 (UTC) In-Reply-To: (martin rudalics's message of "Sun, 7 Apr 2024 10:22:40 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282969 Archived-At: >>> One problem is that I can't find an alist item to limit >>> the window height, i.e. can't find window-max-height >>> that would be like window-min-height, but to set a max height. >>> Could you suggest such an alist item? >> >> The intention was to have such behavior: >> 1. after the first call that adds 1 line to the output buffer, >> resize the displayed buffer to 1 line height; >> 2. after the second call grow the output window height to 2 lines, >> it seems fit-window-to-buffer should do this; >> 3. after 10th call limit the window height to 10 lines only, >> so later calls should not increase the output window height >> more than 10 lines. > > You mean that when a 'window-height' action alist entry is provided that > specifies 'fit-window-to-buffer' as 'window-height' value, we should > pass it the value of any 'window-max-height' entry present as MAX-HEIGHT > argument here > > ((functionp height) > (ignore-errors (funcall height window)) > > and probably do the same for all the other arguments of > 'fit-window-to-buffer'? Probably we can't change the existing arguments to not break backward-compatibility. But this is fine since still can use the explicit function call: diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index 8b43c6a8726..75b519067ac 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -362,7 +362,12 @@ display-warning (or (< (warning-numeric-level level) (warning-numeric-level warning-minimum-level)) (warning-suppress-p type warning-suppress-types) - (let ((window (display-buffer buffer))) + (let ((window (display-buffer + buffer + '(display-buffer--maybe-at-bottom + (window-height . (lambda (window) + (fit-window-to-buffer window 10))) + (category . warning))))) (when (and (markerp warning-series) (eq (marker-buffer warning-series) buffer)) (set-window-start window warning-series)) diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 779c612f479..3344402c893 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1866,7 +1866,11 @@ flymake-show-buffer-diagnostics (current-buffer))))) (with-current-buffer target (setq flymake--diagnostics-buffer-source source) - (display-buffer (current-buffer)) + (display-buffer (current-buffer) + `((display-buffer-reuse-window + display-buffer-below-selected) + (window-height . (lambda (window) + (fit-window-to-buffer window 10))))) (revert-buffer))))