From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70145: [PATCH] Add sqlite-execute-batch command Date: Sat, 13 Apr 2024 11:03:53 +0300 Message-ID: <86a5lxr8nq.fsf@gnu.org> References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> <87o7arciop.fsf@neverwas.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34478"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70145@debbugs.gnu.org, jp@neverwas.me To: Javier Olaechea Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 10:05:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvYNg-0008mh-Qs for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 10:05:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvYNb-0006Fm-DC; Sat, 13 Apr 2024 04:04:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvYNY-0006DV-TZ for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 04:04:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvYNY-0007Yd-Ko for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 04:04:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvYNi-0007jk-UV for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 04:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 08:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70145 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70145-submit@debbugs.gnu.org id=B70145.171299545729326 (code B ref 70145); Sat, 13 Apr 2024 08:05:02 +0000 Original-Received: (at 70145) by debbugs.gnu.org; 13 Apr 2024 08:04:17 +0000 Original-Received: from localhost ([127.0.0.1]:60050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYMy-0007cv-PC for submit@debbugs.gnu.org; Sat, 13 Apr 2024 04:04:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYMw-0007bY-Af for 70145@debbugs.gnu.org; Sat, 13 Apr 2024 04:04:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvYMg-0007Tp-CL; Sat, 13 Apr 2024 04:03:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RFSE9NWTEYyfYrpVCOkB66cXTrKFWk7QME5JQXANi9c=; b=Ks/fcW1okfpx bgj9f6mld6VIgCAGy9IRuggqWEhdorCe2kfofPjlHxBW0fZ8PNgRjAbWYx8AsgM6LKUqD7Q//Csm9 b/dnOz4mmjt1PQ4EBuobaU19v45RmUydFUtyq0s7+9Pr49Hg+yMkzw2sn+sq7VeW0ko37uoMpZWTs 9SC39uhVQE2zQP+qBxHcar/127ZV1ynuKTi6q58tH3DExGYCncthd79CZuNErFF4TX5NhALxEWNFP 000I7nk6A5ofAqqLQJojaXntNR5WBsgxLsgJzhmWZfI4FDEAgdMIZgT6Q2TsJR+kzo5sLegBeR9cM fWjaru72CWSl9yzYRwx9Xg==; In-Reply-To: (message from Javier Olaechea on Tue, 2 Apr 2024 21:42:06 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283186 Archived-At: > From: Javier Olaechea > Date: Tue, 2 Apr 2024 21:42:06 -0500 > Cc: Eli Zaretskii , 70145@debbugs.gnu.org > > Thanks for working on this. I think Emacs applications will find it > handy for things like initializing a new database. Just a couple things > I spotted in passing. (I don't really know anything, though, so feel > free to ignore.) > > Feedback is always welcome. It's not like I know anything either ^_^'. > > I think there's also a test/src/sqlite-tests.el file, which seems to > contain tests for those primitives defined in src/sqlite.c. Perhaps this > test should go there instead? > > Thanks for pointing that out, I hadn't seen that file. It does seem like a better home for the test. > > > diff --git a/test/lisp/sqlite-tests.el b/test/lisp/sqlite-tests.el > > index d4892a27efc..7053026eb82 100644 > > --- a/test/lisp/sqlite-tests.el > > +++ b/test/lisp/sqlite-tests.el > > @@ -48,4 +48,29 @@ with-sqlite-transaction/rollback > > ;; First insertion (a=1) rolled back. > > (should-not (sqlite-select db "select * from test")))) > > > > +(ert-deftest with-sqlite-execute-batch-test () > > Maybe I'm mistaken, but I don't think you need the "with-" part (or the > "-test" part), no? > > I did find it contrary to the foo-test- prefix I've seen in the elisp code in the wild, but on matters of naming > conventions I try to follow the motto: "When in Rome, do as Romans do". So I named the test according to the > other tests in the file. Now that I placed it under test/src/sqlite-tests.el I've changed the name to align with the > names of the test in that file. > > I've attached a new patch incorporating your feedback Thanks. This should have a NEWS entry announcing the new command. Also, to accept this contribution, we'd need a copyright assignment from you. Would you like to start the paperwork for that at this time? If yes, I will send you the form to fill and the instructions to go with it.