Re: Stipples support in MS-Windows port

["Elijah G." <eg642616@gmail.com>]

Yuri Khan <yuri.v.khan@gmail.com> writes:

> 1. you invert a RECT defined by coordinates where you draw the
> stipple, and that is most likely outside the bounds of the stipple
> bitmap;
> 2. you’re doing it on each draw of this stipple rather than once, so
> if you fix the RECT, you’ll be inverting the stipple each time so
> odd-numbered draw calls will come out okay but even-numbered draw
> calls will again be inverted.

Thanks you, at first it works, but increasing or decreasing text scale
doesn't invert the rect, I'm trying to figure how to calling it once.

Also I'm wondering if it's better invert bitmap pixels before using
_w32_create_pixmap_from_bitmap_data_

Like this:

  for (int i = 0; i < (width + 7) / 8; i++)
    bits[i] = (~(bits[i]));
  stipple = w32_create_pixmap_from_bitmap_data (width, height, bits);

Here is the code:
--8<---------------cut here---------------start------------->8---
@@ -56,10 +56,12 @@ #define CP_DEFAULT 1004
 
 struct w32_bitmap_record
 {
   Emacs_Pixmap pixmap;
   char *file;
+  Emacs_Pixmap stipple;
+  bool_bf stipple_applied_p;
   HINSTANCE hinst; /* Used to load the file */
   int refcount;
   /* Record some info about this pixmap.  */
   int height, width, depth;
 };
--8<---------------cut here---------------end--------------->8---


--8<---------------cut here---------------start------------->8---
static void
w32_fill_stipple_pattern (HDC hdc, struct glyph_string *s, Emacs_GC *gc,
			  int x, int y, unsigned int width, unsigned int height)
{
  SetTextColor (hdc, gc->foreground);
  SetBkColor (hdc, gc->background);

  RECT r;
  r.left = x;
  r.top = y;
  r.right = x + width;
  r.bottom = y + height;

  Emacs_Pixmap bm;
  bm = FRAME_DISPLAY_INFO (s->f)->bitmaps[s->face->stipple - 1].stipple;

  /* Windows mono bitmaps are reversed compared with X.  */
  HDC compat_dc;

  if (FRAME_DISPLAY_INFO (s->f)
	->bitmaps[s->face->stipple - 1]
	.stipple_applied_p
      != true)
    {
      compat_dc = CreateCompatibleDC (hdc);

      SelectObject (compat_dc, bm);

      RECT r2;
      r2.left = 0;
      r2.top = 0;
      r2.right = width;
      r2.bottom = height;

      InvertRect (compat_dc, &r2);
    }

  HBRUSH hb = CreatePatternBrush (bm);
  FillRect (hdc, &r, hb);

  DeleteObject (hb);
  if (FRAME_DISPLAY_INFO (s->f)
	->bitmaps[s->face->stipple - 1]
	.stipple_applied_p
      != true)
    {
      DeleteDC (compat_dc);
      FRAME_DISPLAY_INFO (s->f)
	->bitmaps[s->face->stipple - 1]
	.stipple_applied_p
	= true;
    }
}
--8<---------------cut here---------------end--------------->8---