From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71274: 30.0.50; assertion failed: w->window_end_valid, in find_first_unchanged_at_end_row Date: Mon, 03 Jun 2024 21:14:56 +0300 Message-ID: <86a5k1lwpr.fsf@gnu.org> References: <86le3rr0lm.fsf@gnu.org> <86plt2p762.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71274@debbugs.gnu.org To: Daniel Clemente Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 03 20:39:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sECaR-0009OP-Sy for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Jun 2024 20:39:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sECa5-0001wV-L8; Mon, 03 Jun 2024 14:38:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sECa2-0001vm-Hl for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2024 14:38:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sECa2-0006DL-5l for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2024 14:38:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sECaE-0005v8-Gh for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2024 14:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jun 2024 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71274 X-GNU-PR-Package: emacs Original-Received: via spool by 71274-submit@debbugs.gnu.org id=B71274.171743992522703 (code B ref 71274); Mon, 03 Jun 2024 18:39:02 +0000 Original-Received: (at 71274) by debbugs.gnu.org; 3 Jun 2024 18:38:45 +0000 Original-Received: from localhost ([127.0.0.1]:55641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sECZx-0005u4-AY for submit@debbugs.gnu.org; Mon, 03 Jun 2024 14:38:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sECZu-0005tS-Bp for 71274@debbugs.gnu.org; Mon, 03 Jun 2024 14:38:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sECD1-0006J6-FB; Mon, 03 Jun 2024 14:15:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=S5CPs7wtC+eqRoPdEuVUHZrwL/8j/mPAM18k3W5LzFY=; b=iLX7f4uvPd5NxoW9EnoU BpRXZODPj1/nVm5dJQbfTcE5bruRmSGgH1YssrKBJU/sujS278K1z6QnchdcDgfru7HKOaoNCjyjZ MFKWjW+GbMqqGRxdgI8KWZO2zG82w7y7HyDNrLUGi6fSnS/Jf4JOqO8dmO2YD0gDCjXmZecn6gf6V /6WnrVQZZlLX6qYwxkm7PWsPMMJ0I4LBE4aBWpozyKpic3EZAxU00t4ck2weHuO4ywh/ezrobuoHC 0eiy1mGjgf+xtb3Gcx05g4+T7XNLlxHMwgDoqsQlrn0bagnT44ytN6AnKnNVC7tlRm2/cwmJgtOQA zpHTifNqMTX8xA==; In-Reply-To: (message from Daniel Clemente on Mon, 3 Jun 2024 17:50:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286483 Archived-At: > From: Daniel Clemente > Date: Mon, 3 Jun 2024 17:50:47 +0000 > Cc: 71274@debbugs.gnu.org > > > Thanks, but please find where it changes inside the call to > > init_to_row_end, because I couldn't see anything obvious in the code > > involved in that call. There's some factor at work here that we need > > to identify and understand. > > It happens (window_end_valid becoming false) inside init_iterator, in > init_from_display_pos (called init_to_row_end). Here: > > /* Keep in mind: the call to reseat in init_iterator skips invisible > text, so we might end up at a position different from POS. This > is only a problem when POS is a row start after a newline and an > overlay starts there with an after-string, and the overlay has an > invisible property. Since we don't skip invisible text in > display_line and elsewhere immediately after consuming the > newline before the row start, such a POS will not be in a string, > but the call to init_iterator below will move us to the > after-string. */ > init_iterator (it, w, charpos, bytepos, NULL, DEFAULT_FACE_ID); > > > Inside init_iterator, window_end_valid becomes false during this code > (i.e. it was true just before, and false just after): > > /* If face attributes have been changed since the last redisplay, > free realized faces now because they depend on face definitions > that might have changed. Don't free faces while there might be > desired matrices pending which reference these faces. */ > if (!inhibit_free_realized_faces) > { > if (face_change) > { > face_change = false; > XFRAME (w->frame)->face_change = 0; > free_all_realized_faces (Qnil); > } > else if (XFRAME (w->frame)->face_change) > { > XFRAME (w->frame)->face_change = 0; > free_all_realized_faces (w->frame); > } > } > > I don't know yet which branch runs or what happens inside > free_all_realized_faces, since I didn't see this crash recently. > > Does this give any hint about how window_end_valid could become false? Yes, it does, thanks. I installed a fix which hopefully plugs this. > In next tests I'll run with the latest git version, including your > recent commit eb9afd558ec (which I know is for something different > —SIGWINCH— but who knows, maybe it was related to this bug). I don't think so.