From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: sbaugh@janestreet.com, 72019@debbugs.gnu.org
Subject: bug#72019: [PATCH] Add project argument to project-kill-buffers
Date: Wed, 10 Jul 2024 14:43:19 +0300 [thread overview]
Message-ID: <86a5ipo4ko.fsf@gnu.org> (raw)
In-Reply-To: <8e654f47-04bd-4089-92c4-dfb49132397c@gutov.dev> (message from Dmitry Gutov on Tue, 9 Jul 2024 22:59:46 +0300)
> Date: Tue, 9 Jul 2024 22:59:46 +0300
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> Hi!
>
> On 09/07/2024 21:31, Spencer Baugh wrote:
> > Tags: patch
> >
> >
> > Previously, project-kill-buffers always called (project-current t). A
> > Lisp program could change what project project-kill-buffers operated
> > on by binding project-current-directory-override. However, in some
> > edge cases (for example, if the project was deleted between looking it
> > up and calling project-kill-buffers) this might fail to detect a
> > project, and so (project-current t) would prompt the user.
> >
> > To avoid this, accept the project to kill buffers for as an argument.
> >
> > * lisp/progmodes/project.el (project-kill-buffers): Take project as an
> > optional argument.
>
> LGTM.
>
> Eli, is this okay for emacs-30?
As I wrote a few minutes ago, I don't think I like this change in
principle, let alone for Emacs 30. Feel free to point out where I'm
wrong or what am I missing.
next prev parent reply other threads:[~2024-07-10 11:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 18:31 bug#72019: [PATCH] Add project argument to project-kill-buffers Spencer Baugh
2024-07-09 19:59 ` Dmitry Gutov
2024-07-10 11:43 ` Eli Zaretskii [this message]
2024-07-10 11:19 ` Eli Zaretskii
2024-07-10 13:27 ` Spencer Baugh
2024-07-10 14:32 ` Eli Zaretskii
2024-07-10 15:47 ` Spencer Baugh
2024-07-10 17:32 ` Eli Zaretskii
2024-07-10 17:42 ` Spencer Baugh
2024-07-10 17:54 ` Eli Zaretskii
2024-07-10 18:30 ` Spencer Baugh
2024-07-10 19:00 ` Eli Zaretskii
2024-07-11 0:18 ` Dmitry Gutov
2024-07-11 4:52 ` Eli Zaretskii
2024-07-11 19:47 ` Dmitry Gutov
2024-07-12 5:48 ` Eli Zaretskii
2024-07-16 2:00 ` Dmitry Gutov
2024-07-11 0:11 ` Dmitry Gutov
2024-07-11 4:50 ` Eli Zaretskii
2024-07-11 19:44 ` Dmitry Gutov
2024-07-12 5:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5ipo4ko.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72019@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.