bug#72223: 31.0.50; c-ts-mode-indent-style custom function should accept a `mode`(c/c++) parameter

bug#72223: 31.0.50; c-ts-mode-indent-style custom function should accept a `mode`(c/c++) parameter

[Meow King via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Currently, the `c-ts-mode--get-indent-style` function: 
```
(defun c-ts-mode--get-indent-style (mode)
  "Helper function to set indentation style.
MODE is either `c' or `cpp'."
  (let ((style
         (if (functionp c-ts-mode-indent-style)
             (funcall c-ts-mode-indent-style)
           (alist-get c-ts-mode-indent-style (c-ts-mode--indent-styles mode)))))
    `((,mode ,@style))))
```
We can use `c-ts-mode-indent-style` to customize our indentation.
However, the function doesn't accept a `mode` parameter, without which
we cannot determine the current customizing indentation style of what
language (c/c++).



---


In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.42, cairo version 1.18.0)
Repository revision: 3a790abd869ddadc343710deb0c4368227ba6611
Repository branch: master
System Description: NixOS 24.11 (Vicuna)

bug#72223: 31.0.50; c-ts-mode-indent-style custom function should accept a `mode`(c/c++) parameter

[Eli Zaretskii]

> Date: Sat, 20 Jul 2024 22:10:06 +0800
> From:  Meow King via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> 
> Currently, the `c-ts-mode--get-indent-style` function: 
> ```
> (defun c-ts-mode--get-indent-style (mode)
>   "Helper function to set indentation style.
> MODE is either `c' or `cpp'."
>   (let ((style
>          (if (functionp c-ts-mode-indent-style)
>              (funcall c-ts-mode-indent-style)
>            (alist-get c-ts-mode-indent-style (c-ts-mode--indent-styles mode)))))
>     `((,mode ,@style))))
> ```
> We can use `c-ts-mode-indent-style` to customize our indentation.
> However, the function doesn't accept a `mode` parameter, without which
> we cannot determine the current customizing indentation style of what
> language (c/c++).

Isn't the mode available as the value of major-mode?

bug#72223: 31.0.50; c-ts-mode-indent-style custom function should accept a `mode`(c/c++) parameter

[Eli Zaretskii]

> From: Meow King <mr.meowking@anche.no>
> Cc: 
> Date: Sun, 21 Jul 2024 17:14:35 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Isn't the mode available as the value of major-mode?
> 
> Yes, after testing, this approach is proved to be right.
> 
> My `major-mode` related thoughts was immediately discarded since the
> function call is inside `define-derived-mode` block, and not even the
> `after-hook`. After testing, it is proved that the `major-mode` variable
> is already settled. Though, I think it's better to give it a mention in the doc.
> 
> Thank you for your reply and your awesome work!

Thanks, so I'm closing this bug report.

P.S. Please in the future use Reply All to reply, so that the bug
tracker is CC'ed.