From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 72404@debbugs.gnu.org, jm@pub.pink, maurooaranda@gmail.com,
juri@linkov.net
Subject: bug#72404: 30.0.60; Customization of options is broken
Date: Sun, 04 Aug 2024 10:49:52 +0300 [thread overview]
Message-ID: <86a5hsu3q7.fsf@gnu.org> (raw)
In-Reply-To: <87ttg48863.fsf@gmx.net> (message from Stephen Berman on Thu, 01 Aug 2024 19:28:04 +0200)
> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: john muhl <jm@pub.pink>, juri@linkov.net, maurooaranda@gmail.com,
> 72404@debbugs.gnu.org
> Date: Thu, 01 Aug 2024 19:28:04 +0200
>
> On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman <stephen.berman@gmx.net> wrote:
>
> I did happen to have a bit more time for this problem, and I think I've
> found the cause, a single line in commit 8d354925ddb:
>
> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
> index 693991a6f3e..aa653549dad 100644
> --- a/lisp/wid-edit.el
> +++ b/lisp/wid-edit.el
> @@ -2549,7 +2549,8 @@ widget-checklist-add-item
> (t
> (widget-create-child-value
> widget type (car (cdr chosen)))
> - (widget-specify-selected child)))))
> + ;; (widget-specify-selected child)
> + ))))
> (t
> (error "Unknown escape `%c'" escape)))))
> ;; Update properties.
>
> With this line commented out as in the above patch, I get the expected
> value when carrying out Juri's recipe. Moreover, after making that
> change, I then briefly tested customizing the face widget-unselected
> (which the problematic commit added) to inherit from the default face
> and it shows the labels of unselected check boxes in the default face,
> as it should. So maybe deleting the commented out line above and
> leaving the rest of the change is a sufficient fix. But I have to admit
> I don't know why that line causes the problem, and I haven't done enough
> testing of this change to the widget-unselected face feature, so this is
> just a status report.
Thanks, I installed the above fix.
It turns out the same problem also caused bug#72156, so I've now
merged them.
I'm leaving this bug open, in the hope that you or someone else will
find the root cause for the regression and fix it.
next prev parent reply other threads:[~2024-08-04 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 17:25 bug#72404: 30.0.60; Customization of options is broken Juri Linkov
2024-07-31 18:04 ` Eli Zaretskii
2024-07-31 20:18 ` john muhl
2024-08-01 5:09 ` Eli Zaretskii
2024-08-01 10:12 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-01 17:28 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-04 7:49 ` Eli Zaretskii [this message]
2024-08-04 10:00 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5hsu3q7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72404@debbugs.gnu.org \
--cc=jm@pub.pink \
--cc=juri@linkov.net \
--cc=maurooaranda@gmail.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.