From: Eli Zaretskii <eliz@gnu.org>
To: Cecilio Pardo <cpardo@imayhem.com>
Cc: 73258@debbugs.gnu.org
Subject: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken
Date: Sun, 15 Sep 2024 11:25:18 +0300 [thread overview]
Message-ID: <86a5g9e32p.fsf@gnu.org> (raw)
In-Reply-To: <ce2f5d58-3849-4074-9fcc-606c69044de5@imayhem.com> (message from Cecilio Pardo on Sat, 14 Sep 2024 21:33:00 +0200)
> Date: Sat, 14 Sep 2024 21:33:00 +0200
> From: Cecilio Pardo <cpardo@imayhem.com>
>
> dnd-handle-multiple-urls is called once for each file. This brings
> problems, such that when dropping two directories, emacs open the first
> one on dired, then tries to copy the contents of the second to the
> first. The attached patch fixes this. -- Cecilio Pardo
Thanks.
We cannot remove or make backward-incompatible changes in a public
API. So removing/renaming w32-handle-dropped-file and/or changing its
signature is out of the question. Can you rewrite the patch such that
it keeps this function and its arguments, and just change the
implementation to fix the problem?
Also, please accompany your changes with a ChangeLog-style description
(see CONTRIBUTE for the details), to make the job of installing the
changes easier.
Thanks again for working on this.
next prev parent reply other threads:[~2024-09-15 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 19:33 bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken Cecilio Pardo
2024-09-15 8:25 ` Eli Zaretskii [this message]
2024-09-15 19:22 ` Cecilio Pardo
2024-09-20 11:20 ` Cecilio Pardo
2024-09-20 13:26 ` Eli Zaretskii
2024-09-21 10:11 ` Eli Zaretskii
2024-09-21 13:41 ` Cecilio Pardo
2024-09-22 9:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5g9e32p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73258@debbugs.gnu.org \
--cc=cpardo@imayhem.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.