From: Eli Zaretskii <eliz@gnu.org>
To: "Romain Ouabdelkader" <romain.ouabdelkader@gmail.com>,
"João Távora" <joaotavora@gmail.com>
Cc: 73863@debbugs.gnu.org
Subject: bug#73863: 30.0.91; Unexpected cursor movement with flymake-show-diagnostics-at-end-of-line
Date: Sun, 20 Oct 2024 10:25:07 +0300 [thread overview]
Message-ID: <86a5ezjkx8.fsf@gnu.org> (raw)
In-Reply-To: <CAJ8YToZqn2HDvPgq9YuXiR-S6=xOHvW4G_p-RDFZOC1imm0fNw@mail.gmail.com> (message from Romain Ouabdelkader on Sat, 19 Oct 2024 15:41:05 +0200)
> From: Romain Ouabdelkader <romain.ouabdelkader@gmail.com>
> Date: Sat, 19 Oct 2024 15:41:05 +0200
> Cc: 73863@debbugs.gnu.org
>
> So this problem only happens when the window is not wide enough, and
> the diagnostic wraps to the next screen line?
>
> Yes that's correct, this happens to me quite often when I have two windows open side by side.
This is actually what flymake.el requests the display engine to do: it
asks it to show the cursor on the first character of the diagnostic's
before-string:
(put-text-property 0 1 'cursor t summary)
So when you use C-n, Emacs moves point to the end of the
before-string, but the 'cursor' property tells it to show the cursor
on the first character of the before-string, which is on a previous
screen line. So the display engine obeys and shows the cursor there.
The following simple patch seems to give much better results. João,
is the code in question used by any Flymake feature other than this
new flymake-show-diagnostics-at-end-of-line option? If so, we'll
probably need some condition to move the 'cursor' property to end of
string (assuming you don't object to this solution).
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 9a6b62c..0ef1ed0 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -835,8 +835,12 @@ flymake--eol-overlay-summary
(1- (length diags)))
'face 'flymake-eol-information-face)))))
(t
- (mapconcat #'summarize diags " "))))))
- (put-text-property 0 1 'cursor t summary)
+ (mapconcat #'summarize diags " ")))))
+ (last-pos (1- (length summary))))
+ ;; Put the 'cursor' property on the last character of the summary,
+ ;; so that vertical-motion produces the expected results when the
+ ;; summary wraps to next screen lines.
+ (put-text-property last-pos (1+ last-pos) 'cursor t summary)
summary)))
(defun flymake--update-eol-overlays ()
next prev parent reply other threads:[~2024-10-20 7:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 15:09 bug#73863: 30.0.91; Unexpected cursor movement with flymake-show-diagnostics-at-end-of-line Romain Ouabdelkader
2024-10-18 16:08 ` Eli Zaretskii
2024-10-18 16:24 ` Romain Ouabdelkader
2024-10-18 18:31 ` Eli Zaretskii
2024-10-18 19:10 ` Romain Ouabdelkader
2024-10-19 13:15 ` Eli Zaretskii
2024-10-19 13:41 ` Romain Ouabdelkader
2024-10-20 7:25 ` Eli Zaretskii [this message]
2024-10-20 9:28 ` João Távora
2024-10-20 11:22 ` Eli Zaretskii
2024-10-20 11:38 ` João Távora
2024-10-20 11:49 ` Eli Zaretskii
2024-10-20 14:42 ` João Távora
2024-10-20 15:01 ` Romain Ouabdelkader
2024-10-20 15:49 ` Eli Zaretskii
2024-10-20 16:23 ` Eli Zaretskii
2024-10-20 15:31 ` Eli Zaretskii
2024-10-20 15:39 ` João Távora
2024-10-20 16:30 ` Eli Zaretskii
2024-10-20 16:58 ` João Távora
2024-10-20 17:50 ` Eli Zaretskii
2024-10-20 18:05 ` João Távora
2024-10-20 18:28 ` Eli Zaretskii
2024-10-20 19:18 ` João Távora
2024-10-27 10:56 ` Eli Zaretskii
2024-10-30 23:57 ` Romain Ouabdelkader
2024-10-18 19:16 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 19:25 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5ezjkx8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73863@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=romain.ouabdelkader@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.