From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] configure.ac: Fix FIONREAD check to work with gcc-14 on Solaris Date: Wed, 23 Oct 2024 20:54:59 +0300 Message-ID: <86a5euembw.fsf@gnu.org> References: <20241008210227.27362-2-alan.coopersmith@oracle.com> <865xpxwg3a.fsf@gnu.org> <87fromrhpa.fsf@gentoo.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12218"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, alan.coopersmith@oracle.com, emacs-devel@gnu.org, Ali.Bahrami@oracle.com To: Sam James Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 23 19:55:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3faE-0002zv-Nx for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Oct 2024 19:55:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3fZs-0001Bu-DZ; Wed, 23 Oct 2024 13:55:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3fZf-00016Q-VX for emacs-devel@gnu.org; Wed, 23 Oct 2024 13:55:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3fZW-000316-72; Wed, 23 Oct 2024 13:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rX9I/UDI8bJl73zz8MsPtqLYD0stIg+WT5XuZM8ip48=; b=reWdMBvni6l6 /wCNy0bvsiFWQ9chTwAW8UYj+/UXccHysvS0XWvyuZ4hTQOq28iuUrD4yC13FLYAW+gAN1ZP9EzQE AreMGRCdLpS7cGbtR8Ja8oKicxuAsmlieg53MuCwtPBN+XKo3WPJAhv8yZCUdiaGSq/puoLFfKRNP VBY4fEEIe/m7LomejmxbnwbI3euqECIqd5yKBODr2jU77woz0N9ouWABZjmWcExuJUbvYsbT0eM3j PyMurQFjafNE4bO0ssY514kTFHe0B1VLpqfzUpfSG4LzduZA6UW6o7NmCkGTRnm6R1egQwACZ7Aq7 fNCB/PMmXOzpj0gHGtt2Og==; In-Reply-To: <87fromrhpa.fsf@gentoo.org> (message from Sam James on Wed, 23 Oct 2024 15:56:33 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324799 Archived-At: > From: Sam James > Cc: Stefan Kangas , alan.coopersmith@oracle.com, > emacs-devel@gnu.org, Ali.Bahrami@oracle.com > Date: Wed, 23 Oct 2024 15:56:33 +0100 > > >> I guess this should be installed on emacs-30. Eli, WDYT? > > > > I'd prefer on master. Who knows what addition of unistd.h could cause > > to this test? > > Note that the absence of the include means the configure check gives the > wrong result, it doesn't mean Emacs necessarily fails to build as a > result. It may be built with the wrong configuration. I understand. But Solaris isn't a very important platform for us to risk screwing other platforms, when we are quite close to a release, and people who want to build Emacs 30 on Solaris can always apply this change by hand.