all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Sam James <sam@gentoo.org>
Cc: stefankangas@gmail.com, alan.coopersmith@oracle.com,
	emacs-devel@gnu.org, Ali.Bahrami@oracle.com
Subject: Re: [PATCH] configure.ac: Fix FIONREAD check to work with gcc-14 on Solaris
Date: Wed, 23 Oct 2024 20:54:59 +0300	[thread overview]
Message-ID: <86a5euembw.fsf@gnu.org> (raw)
In-Reply-To: <87fromrhpa.fsf@gentoo.org> (message from Sam James on Wed, 23 Oct 2024 15:56:33 +0100)

> From: Sam James <sam@gentoo.org>
> Cc: Stefan Kangas <stefankangas@gmail.com>,  alan.coopersmith@oracle.com,
>   emacs-devel@gnu.org,  Ali.Bahrami@oracle.com
> Date: Wed, 23 Oct 2024 15:56:33 +0100
> 
> >> I guess this should be installed on emacs-30.  Eli, WDYT?
> >
> > I'd prefer on master.  Who knows what addition of unistd.h could cause
> > to this test?
> 
> Note that the absence of the include means the configure check gives the
> wrong result, it doesn't mean Emacs necessarily fails to build as a
> result. It may be built with the wrong configuration.

I understand.  But Solaris isn't a very important platform for us to
risk screwing other platforms, when we are quite close to a release,
and people who want to build Emacs 30 on Solaris can always apply this
change by hand.



  reply	other threads:[~2024-10-23 17:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08 20:58 [PATCH] configure.ac: Fix FIONREAD check to work with gcc-14 on Solaris Alan Coopersmith
2024-10-12 13:20 ` Stefan Kangas
2024-10-12 14:28   ` Eli Zaretskii
2024-10-23 13:48     ` Stefan Kangas
2024-10-23 14:56     ` Sam James
2024-10-23 17:54       ` Eli Zaretskii [this message]
2024-10-23 18:10         ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a5euembw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=Ali.Bahrami@oracle.com \
    --cc=alan.coopersmith@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=sam@gentoo.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.