From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74193: 30.0.92; noquery argument ignored when creating a TLS connection Date: Mon, 04 Nov 2024 14:01:53 +0200 Message-ID: <86a5efw6ku.fsf@gnu.org> References: <87cyjc6v8n.fsf@ars3.mail-host-address-is-not-set> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2435"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74193@debbugs.gnu.org To: Augusto Stoffel , Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 04 13:03:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7vnw-0000UY-9n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Nov 2024 13:03:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7vni-0008T6-CV; Mon, 04 Nov 2024 07:03:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7vnX-0008Q7-02 for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2024 07:03:07 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7vnS-0004Kh-SI for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2024 07:03:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=3QFTjfGqSUeFt2TL0ORPvsrTQI55KuAXw/dJPlswT7s=; b=Qrp5YWkBNQtyTBGD6bGP1/6lLXZzCE2UMPukiUhc4nawXccSd352uXp3bFdvzV6sGVPdiFPDjM0xiIZHdA6oI4OjX4i6xooxR3MEDGEHx8zk7cyQC/kU3lBBBdq1O/Y9KuNIwzyphR1zTsuwKJg8FFVSe45CAC9tmHr3JI1fI0wxXrj290maspdjz9lyme/NIXSpHSg8yqruzH8jqSioyRifa0gN036TKfY6q50YbOHIDaz+JXhbBVj2vJYmNCkzW4wawwYa00/YWL2ZRJ4IqNRQlC+raRPB038ItLLSSrT9h072ice87zmWaS9kZoXdAEBcy8EBs/LUhciiuamIDA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t7vnS-0008RK-FF for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2024 07:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Nov 2024 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74193 X-GNU-PR-Package: emacs Original-Received: via spool by 74193-submit@debbugs.gnu.org id=B74193.173072172632402 (code B ref 74193); Mon, 04 Nov 2024 12:03:02 +0000 Original-Received: (at 74193) by debbugs.gnu.org; 4 Nov 2024 12:02:06 +0000 Original-Received: from localhost ([127.0.0.1]:39413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7vmY-0008QY-2Y for submit@debbugs.gnu.org; Mon, 04 Nov 2024 07:02:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7vmV-0008Q4-8d for 74193@debbugs.gnu.org; Mon, 04 Nov 2024 07:02:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7vmP-0004EN-LD; Mon, 04 Nov 2024 07:01:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3QFTjfGqSUeFt2TL0ORPvsrTQI55KuAXw/dJPlswT7s=; b=f7MAX8LZD93D I8iZ3hLjVR2b1lIH9SymyjuZzKVa1/kGizbIB1SBC+y9bfX05ZCSVoKDeyFzHlyQxeBCFRcBcftj0 13NL3lY2EywbE+0lPWriqgKsjkZ+cvA+gshgXH/HZtP3kgBnKj/c5azxtgu0op2QrhlhDwQ7qBEs2 tB6hi0YraprFv47ZT2KBrC3gRDXGgp6GaU00v1ntFZf4IHmbMHffEMmsyiQolgKJuODDbrFZzhzf6 l30okjCLyjM2B3gv6usRdPVzrK1bpEAg3vzLdND/aq51EY01H9xwDizNaDPrhNOO7HCY81KksdpbB hqWmTgasq7gULye8uZwEpQ==; In-Reply-To: <87cyjc6v8n.fsf@ars3.mail-host-address-is-not-set> (message from Augusto Stoffel on Sun, 03 Nov 2024 19:13:44 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294842 Archived-At: > From: Augusto Stoffel > Cc: Augusto Stoffel , 74193@debbugs.gnu.org > Date: Sun, 03 Nov 2024 19:13:44 +0100 > > On Sun, 3 Nov 2024 at 19:44, Eli Zaretskii wrote: > > > AFAICT, open-gnutls-stream doesn't support :noquery, so Emacs > > basically ignores :noquery in this case and starts a network process > > with query-on-exit flag set. > > Indeed, the fix is trivial: > > > >From 01d73dea9243d2b57b6ed2bd0fa37e0935ef7a74 Mon Sep 17 00:00:00 2001 > From: Augusto Stoffel > Date: Sun, 3 Nov 2024 19:11:54 +0100 > Subject: [PATCH] * lisp/net/gnutls.el (open-gnutls-stream): Use :noquery > option > > --- > lisp/net/gnutls.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/net/gnutls.el b/lisp/net/gnutls.el > index b5fb4d47d57..e8614bfc6d3 100644 > --- a/lisp/net/gnutls.el > +++ b/lisp/net/gnutls.el > @@ -200,6 +200,7 @@ open-gnutls-stream > (process (open-network-stream > name buffer host service > :nowait nowait > + :noquery (plist-get parameters :noquery) > :tls-parameters > (and nowait > (cons 'gnutls-x509pki Thanks. Robert, do you know if GnuTLS, as we use it in Emacs, supports this on all platforms? With both :nowait and non-:nowait? More generally, I wonder why we don't pass all the parameters to open-network-stream? In any case, the doc string should be fixed to mention :noquery.