From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74999: [PATCH v3] Recommend `keymap-set' instead of `define-key' in emacs lisp intro Date: Fri, 27 Dec 2024 09:37:28 +0200 Message-ID: <86a5chy3t3.fsf@gnu.org> References: <86y1098pvj.fsf@gnu.org> <20241221080552.259664-1-hong@topbug.net> <86ed1uzwhw.fsf@gnu.org> <87msgip0mu.fsf@topbug.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74999@debbugs.gnu.org To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 27 08:38:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tR4vS-0003PU-WA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Dec 2024 08:38:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tR4v7-0002X1-QJ; Fri, 27 Dec 2024 02:38:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tR4v5-0002Wd-Ib for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 02:38:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tR4v5-0007wl-9Q for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 02:38:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=sRkEFSPbsOTNY3GFzltzm1fyB4wH/LW+2WDZ8N2mAHI=; b=Csz1sn1sPnZetyT2p4hdGpk7DuoqfVGoIIBGFRWGHdZg0sS18LJ4C+NiylDVuD28ZD3HiJsciqnM9d1NrQpDKPJ4VgBIXYQmKJLxCOeppD38GhXKaalXWAGk1WvWfnEGdr3dJ9wjbsr1p+xL8vDVFCNNCf4u6IxpCywzdSUxgQZahu4n3usX7XPmD63GCX7WFxSF7GUQjUjBLk+Ln4yeXuOri4K+uFOSlOCPX/S5aPQlWefu8/G/dm9rph7s/ENaIiEfYjkG75MeJ8+6c94g35bkdMQCQ3+ABRr3wWr4YBMPXTbpUbBF7QLkIFXJccnFLsrNbCjdMzvRkBSUr20DNg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tR4v4-0000hC-7L for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 02:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Dec 2024 07:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74999 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74999-submit@debbugs.gnu.org id=B74999.17352850582640 (code B ref 74999); Fri, 27 Dec 2024 07:38:02 +0000 Original-Received: (at 74999) by debbugs.gnu.org; 27 Dec 2024 07:37:38 +0000 Original-Received: from localhost ([127.0.0.1]:44525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tR4ug-0000gW-CM for submit@debbugs.gnu.org; Fri, 27 Dec 2024 02:37:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tR4ud-0000gH-Tw for 74999@debbugs.gnu.org; Fri, 27 Dec 2024 02:37:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tR4uY-0007vp-5V; Fri, 27 Dec 2024 02:37:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sRkEFSPbsOTNY3GFzltzm1fyB4wH/LW+2WDZ8N2mAHI=; b=Jpa2BIIZw4q8 8IxuXzFfJ8m0hga2QYU1ITl1OzLep38FJj7cp3PeI33egm+BlPzfGILvO5lqQLpX7wjqV2GS9jbRC jMQpGgrc83ijjiKcVewUo7kKZUAkxMucOFEym3cCHgOy38XuaoS4TsJPdfWnWE6uLoRKRJVeTT0na Jh5RKfuxq88rfj6WSUwTBIEzN8a0nYzji8NWz/xiZSOHAqTKDaFMgiMHWvOaeXF2EotGLha3vpji/ 24SRhIkG/+TfX1/AHCeUpRNV6VVeUaEVDIrfmtZlnyIQKfnDgoInGjmyw6oCp2StP+f6k7kbosSUq jfRJ2xKlwNFjW936pvhBRg==; In-Reply-To: <87msgip0mu.fsf@topbug.net> (message from Hong Xu on Thu, 26 Dec 2024 13:58:33 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297805 Archived-At: > From: Hong Xu > Cc: 74999@debbugs.gnu.org > Date: Thu, 26 Dec 2024 13:58:33 -0800 > > > Thanks. I tried to install this, but the git-commit hook rejected the > > commit because Subject line is too long: > > > > Line longer than 78 characters in commit message > > Commit aborted; please see the file CONTRIBUTE > > > > Please format the patch using "git format-patch", and please commit > > the patch locally before you do so (assuming you have the hooks in > > your local clone), to make sure these problems are corrected before > > you send the patch here. > > I could apply these patches without line length complaints, and the > hooks were in effect. An inspection into the patch file also shows no > line is longer than 78 characters. Git is supposed to abandon the > "[Patch vN]" prefix when applying the patch. I'm guessing the problem on my side is because you sent the patch as a complete email message, where the heading line is presumed to be taken from Subject. To avoid these problems, please in the future send the patches as attachments, to allow me to pass to "git am" only the actual patch, not any of the other email headers.