From: Eli Zaretskii <eliz@gnu.org>
To: Hong Xu <hong@topbug.net>
Cc: 74999@debbugs.gnu.org
Subject: bug#74999: [PATCH v3] Recommend `keymap-set' instead of `define-key' in emacs lisp intro
Date: Fri, 27 Dec 2024 09:37:28 +0200 [thread overview]
Message-ID: <86a5chy3t3.fsf@gnu.org> (raw)
In-Reply-To: <87msgip0mu.fsf@topbug.net> (message from Hong Xu on Thu, 26 Dec 2024 13:58:33 -0800)
> From: Hong Xu <hong@topbug.net>
> Cc: 74999@debbugs.gnu.org
> Date: Thu, 26 Dec 2024 13:58:33 -0800
>
> > Thanks. I tried to install this, but the git-commit hook rejected the
> > commit because Subject line is too long:
> >
> > Line longer than 78 characters in commit message
> > Commit aborted; please see the file CONTRIBUTE
> >
> > Please format the patch using "git format-patch", and please commit
> > the patch locally before you do so (assuming you have the hooks in
> > your local clone), to make sure these problems are corrected before
> > you send the patch here.
>
> I could apply these patches without line length complaints, and the
> hooks were in effect. An inspection into the patch file also shows no
> line is longer than 78 characters. Git is supposed to abandon the
> "[Patch vN]" prefix when applying the patch.
I'm guessing the problem on my side is because you sent the patch as a
complete email message, where the heading line is presumed to be taken
from Subject. To avoid these problems, please in the future send the
patches as attachments, to allow me to pass to "git am" only the
actual patch, not any of the other email headers.
next prev parent reply other threads:[~2024-12-27 7:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 22:36 bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Hong Xu
2024-12-20 7:01 ` Eli Zaretskii
2024-12-20 9:35 ` Stefan Kangas
2024-12-20 21:42 ` bug#74999: [PATCH v2] Recommend " Hong Xu
2024-12-21 7:19 ` Eli Zaretskii
2024-12-21 8:03 ` bug#74999: [PATCH v3] " Hong Xu
2024-12-23 20:42 ` Hong Xu
2024-12-24 3:27 ` Eli Zaretskii
2024-12-26 8:20 ` Eli Zaretskii
2024-12-26 21:46 ` bug#74999: [PATCH v4] Use `keymap*-set' over `global-set-key'/`define-key' in elisp intro Hong Xu
2024-12-26 22:05 ` Hong Xu
2024-12-27 7:44 ` Eli Zaretskii
2024-12-26 21:58 ` bug#74999: [PATCH v3] Recommend `keymap-set' instead of `define-key' in emacs lisp intro Hong Xu
2024-12-27 7:37 ` Eli Zaretskii [this message]
2024-12-21 8:06 ` bug#74999: [PATCH v2] " Hong Xu
2024-12-20 15:43 ` bug#74983: [PATCH] Use " Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-20 21:50 ` Hong Xu
2024-12-21 7:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5chy3t3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74999@debbugs.gnu.org \
--cc=hong@topbug.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.