From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: Warning compiling xref.el Date: Thu, 05 Nov 2015 07:32:53 -0600 Message-ID: <868u6cy3ju.fsf@stephe-leake.org> References: <83twp1u5jh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446730422 15010 80.91.229.3 (5 Nov 2015 13:33:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Nov 2015 13:33:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 05 14:33:31 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZuKfS-0005ay-Pr for ged-emacs-devel@m.gmane.org; Thu, 05 Nov 2015 14:33:30 +0100 Original-Received: from localhost ([::1]:60650 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuKfR-0004vD-Rg for ged-emacs-devel@m.gmane.org; Thu, 05 Nov 2015 08:33:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuKfD-0004uv-LT for emacs-devel@gnu.org; Thu, 05 Nov 2015 08:33:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuKf8-0007h4-Ox for emacs-devel@gnu.org; Thu, 05 Nov 2015 08:33:15 -0500 Original-Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:33313) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ZuKf8-0007fh-J5 for emacs-devel@gnu.org; Thu, 05 Nov 2015 08:33:10 -0500 Original-Received: (qmail 5211 invoked by uid 0); 5 Nov 2015 13:33:05 -0000 Original-Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy4.mail.unifiedlayer.com with SMTP; 5 Nov 2015 13:33:05 -0000 Original-Received: from host114.hostmonster.com ([74.220.207.114]) by CMOut01 with id dpYv1r01E2UdiVW01pYyX6; Thu, 05 Nov 2015 06:33:04 -0700 X-Authority-Analysis: v=2.1 cv=VOBOwb/X c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=qtqOOiqGOCEA:10 a=mDV3o1hIAAAA:8 a=dh3mZdTTviT8C6uGsHQA:9 Original-Received: from [76.218.37.33] (port=50007 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1ZuKeu-0007nw-Qq; Thu, 05 Nov 2015 06:32:56 -0700 In-Reply-To: <83twp1u5jh.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Nov 2015 17:51:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 69.89.23.142 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193293 Archived-At: Eli Zaretskii writes: > I get this warning when compiling the latest xref.el: > > In xref-collect-references: > ../lisp/progmodes/xref.el:883:21:Warning: Unknown slot `hit-lines' It's due to this code: (defun xref-collect-references (symbol dir) "Collect references to SYMBOL inside DIR. This function uses the Semantic Symbol Reference API, see `semantic-symref-find-references-by-name' for details on which tools are used, and when." (cl-assert (directory-name-p dir)) (require 'semantic/symref) (defvar semantic-symref-tool) (let* ((default-directory dir) (semantic-symref-tool 'detect) (res (semantic-symref-find-references-by-name symbol 'subdirs)) (hits (and res (oref res hit-lines))) (orig-buffers (buffer-list))) 'hit-lines' is a slot defined in semantic/symref.el, but the byte-compiler does not process the "require" in this defun, apparently, Adding this: (eval-when-compile (require 'semantic/symref)) ;; for hit-lines slot outside the defun fixes the problem for me. -- -- Stephe