Warning compiling xref.el

Warning compiling xref.el

[Eli Zaretskii]

I get this warning when compiling the latest xref.el:

  In xref-collect-references:
  ../lisp/progmodes/xref.el:883:21:Warning: Unknown slot `hit-lines'

Re: Warning compiling xref.el

[Stephen Leake]

Eli Zaretskii <eliz@gnu.org> writes:

> I get this warning when compiling the latest xref.el:
>
>   In xref-collect-references:
>   ../lisp/progmodes/xref.el:883:21:Warning: Unknown slot `hit-lines'

It's due to this code:

(defun xref-collect-references (symbol dir)
  "Collect references to SYMBOL inside DIR.
This function uses the Semantic Symbol Reference API, see
`semantic-symref-find-references-by-name' for details on which
tools are used, and when."
  (cl-assert (directory-name-p dir))
  (require 'semantic/symref)
  (defvar semantic-symref-tool)
  (let* ((default-directory dir)
         (semantic-symref-tool 'detect)
         (res (semantic-symref-find-references-by-name symbol 'subdirs))
         (hits (and res (oref res hit-lines)))
         (orig-buffers (buffer-list)))

'hit-lines' is a slot defined in semantic/symref.el, but the
byte-compiler does not process the "require" in this defun, apparently,

Adding this:

(eval-when-compile
  (require 'semantic/symref)) ;; for hit-lines slot

outside the defun fixes the problem for me.

-- 
-- Stephe

Re: Warning compiling xref.el

[Dmitry Gutov]

On 11/05/2015 03:32 PM, Stephen Leake wrote:

> Adding this:
>
> (eval-when-compile
>    (require 'semantic/symref)) ;; for hit-lines slot
>
> outside the defun fixes the problem for me.

Applied, thank you.