all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: dick <dick.r.chiang@gmail.com>
Cc: "Lars Ingebrigtsen" <larsi@gnus.org>,
	"Dmitry Gutov" <dgutov@yandex.ru>,
	"Rudolf Adamkovič" <salutis@me.com>,
	54359@debbugs.gnu.org
Subject: bug#54359: 29.0.50; [PATCH] Undo breaking change to project interface
Date: Sat, 19 Mar 2022 20:57:12 +0200	[thread overview]
Message-ID: <868rt5vky7.fsf@mail.linkov.net> (raw)
In-Reply-To: <87ee2z8ntq.fsf@dick> (dick's message of "Fri, 18 Mar 2022 08:09:05 -0400")

>> There is no bug.
>
> I noticed all emacs developers, myself included, say this about their
> own code.
>
> It's fine.  Of the four people in the world using project.el, I suspect
> only half of them rely on `(cdr (project-current))` being an atom
> instead of a list.

I'm the fifth user of project.el and after that change
just quietly replaced in my code

-                 (let ((project (cdr (project-current nil directory))))
-                   (when project

with more correct code that doesn't rely on internal data structure

+                 (let* ((project (project-current nil directory))
+                        (root (when project (project-root project))))





  reply	other threads:[~2022-03-19 18:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-12 21:47 bug#54359: 29.0.50; [PATCH] Undo breaking change to project interface dick
2022-03-13  5:48 ` Eli Zaretskii
2022-03-14 19:35   ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-17 11:28     ` Lars Ingebrigtsen
2022-03-18  0:56       ` Dmitry Gutov
2022-03-18  9:33         ` Lars Ingebrigtsen
2022-03-18 11:02           ` dick
2022-03-18 11:27           ` Dmitry Gutov
2022-03-18 12:09             ` dick
2022-03-19 18:57               ` Juri Linkov [this message]
2022-03-19 14:19             ` Lars Ingebrigtsen
2022-03-19 23:45               ` Dmitry Gutov
2022-03-14 10:38 ` Lars Ingebrigtsen
2022-03-18  0:58   ` Dmitry Gutov
2022-03-18  1:13     ` dick
2022-03-18 11:25       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868rt5vky7.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=54359@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=dick.r.chiang@gmail.com \
    --cc=larsi@gnus.org \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.