From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (for Git) Date: Mon, 13 Nov 2023 09:02:35 +0200 Organization: LINKOV.NET Message-ID: <868r72895g.fsf@mail.linkov.net> References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@gmail.com> <83y1f4wxby.fsf@gnu.org> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@gutov.dev> <83sf5bv77j.fsf@gnu.org> <83bkbzusri.fsf@gnu.org> <86msvi95aw.fsf@mail.linkov.net> <8742d731-62ba-0808-bdc6-cbad1cf98116@gutov.dev> <2f7c9164-4a64-91c6-245e-61208de8560c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35130"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , Eli Zaretskii , 67062@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 13 08:09:54 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2R4x-0008st-Be for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Nov 2023 08:09:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2R4Y-0004mj-MV; Mon, 13 Nov 2023 02:09:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2R4U-0004lm-0U for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 02:09:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2R4T-0006KU-3Z for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 02:09:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2R58-0006NY-F8 for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 02:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2023 07:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67062-submit@debbugs.gnu.org id=B67062.169985935524436 (code B ref 67062); Mon, 13 Nov 2023 07:10:02 +0000 Original-Received: (at 67062) by debbugs.gnu.org; 13 Nov 2023 07:09:15 +0000 Original-Received: from localhost ([127.0.0.1]:57447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2R4N-0006M4-FG for submit@debbugs.gnu.org; Mon, 13 Nov 2023 02:09:15 -0500 Original-Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:56359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2R4K-0006Lj-Ig for 67062@debbugs.gnu.org; Mon, 13 Nov 2023 02:09:14 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 9EC0FC0005; Mon, 13 Nov 2023 07:08:23 +0000 (UTC) In-Reply-To: <2f7c9164-4a64-91c6-245e-61208de8560c@gmail.com> (Jim Porter's message of "Sun, 12 Nov 2023 14:13:58 -0800") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274247 Archived-At: > We just want to take that revision and turn it into a friendlier > (read: shorter) form for the buffer name. Then the best solution is to introduce a new variable 'vc-short-revision' that vc-annotate should either set as a buffer-local value or let-bind around the vc backend API call. Then the git backend could use it optionally depending on the value of a new user option 'vc-git-short-revision'. This is much better that adding a new API call. We don't add new API calls lightly since any change in API requires updating the documentation at the top of vc.el and at the top of vc backend implementation files.