From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 8163e0b20c9: Improve 'refill-mode' in Org buffers Date: Sat, 27 Jan 2024 13:29:06 +0200 Message-ID: <868r4b816l.fsf@gnu.org> References: <170634561249.8419.14120799276160131850@vcs2.savannah.gnu.org> <20240127085332.C6466C4068B@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11086"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Arash Esbati Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 27 12:29:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTgsJ-0002gS-KE for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Jan 2024 12:29:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTgs2-0006Pt-L9; Sat, 27 Jan 2024 06:29:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTgs0-0006Ox-9L for emacs-devel@gnu.org; Sat, 27 Jan 2024 06:29:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTgs0-0007Om-0d for emacs-devel@gnu.org; Sat, 27 Jan 2024 06:29:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XWS7+Uh+HEVOf3iCKuftvO4HCJreebc27ARl+ur1LZ0=; b=f6lAKxF9ouDJwbjZSfCB zaAz1eMpqVgT1Z6RfZSX1gUI2Hf8g0JDK3Ayypyp/Fn2uPMx1ZT0iUjyZf9H7zjmMKLO0VGkpIlVW zOmI+boFaD4qrKEN68hZpHRLXepCFIMbjJjqwX5izdgnJv099dCqQz86UrS8yGCiu2GgzJZrrYqy6 BsSYt9XBJ2l+kjrTVi0aGuoK9aSggRLLHJWQ6s+S6ZyqxP1M5/tmzTSNXypIe0UcQCjFzIfOp53Yp hTVTnTst7bj6ZVJQYFiHfpGVe9utVvH2i4L20ZGFTnDLJE7qVlVRqwn6CP2PaUTMuK7FiyYbnrP9B y1BBUMMkWJ2bmQ==; In-Reply-To: (message from Arash Esbati on Sat, 27 Jan 2024 10:32:00 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315476 Archived-At: > From: Arash Esbati > Cc: Eli Zaretskii > Date: Sat, 27 Jan 2024 10:32:00 +0100 > > Eli Zaretskii writes: > > > branch: master > > commit 8163e0b20c97a8394225a7165a8ab361af09ec29 > > Author: Eli Zaretskii > > Commit: Eli Zaretskii > > > > Improve 'refill-mode' in Org buffers > > > > * lisp/textmodes/refill.el (refill-fill-paragraph-at): Use > > 'fill-forward-paragraph' instead of 'forward/backward-paragraph', > > so that modes could customize the behavior. (Bug#68418) > > --- > > lisp/textmodes/refill.el | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lisp/textmodes/refill.el b/lisp/textmodes/refill.el > > index bb6b6ebda0f..244c96b60df 100644 > > --- a/lisp/textmodes/refill.el > > +++ b/lisp/textmodes/refill.el > > @@ -106,10 +106,10 @@ This is used to optimize refilling.") > > ;; FIXME: forward-paragraph seems to disregard `use-hard-newlines', > > ;; leading to excessive refilling and wrong choice of fill-prefix. > > ;; might be a bug in my paragraphs.el. > > - (forward-paragraph) > > + (fill-forward-paragraph) > > The compiler says: > > In refill-fill-paragraph-at: > textmodes/refill.el:109:6: Warning: ‘fill-forward-paragraph’ called > with 0 arguments, but requires 1 Thanks, should be fixed now.