From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68929: [PATCH] Copy which-key from GNU ELPA into core Date: Sat, 17 Feb 2024 18:58:55 +0200 Message-ID: <868r3jt4c0.fsf@gnu.org> References: <871q9rvqbi.fsf@jeremybryant.net> <86wmrj148c.fsf@gnu.org> <87ttmkrlc5.fsf@jeremybryant.net> <86fry3xzae.fsf@gnu.org> <87zfwar3qd.fsf@jeremybryant.net> <87wmraptwj.fsf@jeremybryant.net> <86r0hew2pc.fsf@gnu.org> <87le7joy9l.fsf@jeremybryant.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35956"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68929-done@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 17 18:00:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rbO34-0009B8-Sk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Feb 2024 18:00:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rbO2T-00085f-Tt; Sat, 17 Feb 2024 11:59:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbO2R-00085I-JT for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2024 11:59:44 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rbO2R-0004pU-Bz for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2024 11:59:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rbO2l-0005lY-1V for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2024 12:00:03 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Feb 2024 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 68929@debbugs.gnu.org, eliz@gnu.org, jb@jeremybryant.net Original-Received: via spool by 68929-done@debbugs.gnu.org id=D68929.170818917222093 (code D ref 68929); Sat, 17 Feb 2024 17:00:02 +0000 Original-Received: (at 68929-done) by debbugs.gnu.org; 17 Feb 2024 16:59:32 +0000 Original-Received: from localhost ([127.0.0.1]:33690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbO2G-0005kH-5g for submit@debbugs.gnu.org; Sat, 17 Feb 2024 11:59:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbO2D-0005k2-8K for 68929-done@debbugs.gnu.org; Sat, 17 Feb 2024 11:59:30 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbO1i-0004nu-55; Sat, 17 Feb 2024 11:58:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=X/D0G3puKQ0p0x6q6k4KyKoynTp7+cjU919458Y/7Ow=; b=GJ5YaNg4jEs2 SS1gwMLLFOVteDiR2rC5JeZ60BYgYvrdqZgC0X+8xwtOjckR1Rd8Q9IOjBpHCr6Hp4Uamb020p/+K p6bhOumbw4nUQbDI8eYCi8MBcy3YYAHjnCnqDONMavy7KBnk34xy1sTx2VtK9yFKyBFJlMkdpWGFO nK2MHQGw50x2xSt7D+5yCkhwVN/bskUlXK+dYUQRrWYE5RB7PjOTpt5qzXOpfh3KNjmjOvjXl7VLO clBXpTDNy3svXKa7g4npwWR8q7Cy95dwsdfV3fjgtoj3jBJ/9wCjo60XcL2aDuE0f1gE4aTH5HDb0 rHzyNh/8ryHffbpaTSptaA==; In-Reply-To: <87le7joy9l.fsf@jeremybryant.net> (message from Jeremy Bryant on Sat, 17 Feb 2024 13:10:51 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280135 Archived-At: > From: Jeremy Bryant > Cc: 68929@debbugs.gnu.org, justin@burkett.cc, monnier@iro.umontreal.ca > Date: Sat, 17 Feb 2024 13:10:51 +0000 > > Eli Zaretskii writes: > > > LGTM, thanks. Some minor comments below. > > Revised patch attached. Thanks. (The argument of @anchor should be in braces; I fixed that.) Installed on master, and closing the bug.