all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Elijah G <eg642616@gmail.com>
Cc: philipk@posteo.net, emacs-devel@gnu.org
Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin
Date: Wed, 13 Mar 2024 14:18:47 +0200	[thread overview]
Message-ID: <868r2mtjdk.fsf@gnu.org> (raw)
In-Reply-To: <CACnP4NJmmuzno0BV-TgBisj2oQEcV8ZuEJKiv_TKerQ4UchHnQ@mail.gmail.com> (message from Elijah G on Tue, 12 Mar 2024 11:22:04 -0600)

> From: Elijah G <eg642616@gmail.com>
> Date: Tue, 12 Mar 2024 11:22:04 -0600
> Cc: emacs-devel@gnu.org
> 
> Thank you, I've fixed my patch.

Thanks, I have a few more comments below.

> Also I merged every flymake *-bitmap variable 
> into a single user option. 

I think this is a mistake: it makes this change backward-incompatible,
in the sense that users who had customizations of the options you are
removing will now have to rework their customizations.  We try to
avoid backward-incompatible changes like this as much as possible.  It
doesn't sound to me like this part of the patch is strictly needed, is
it?

> +  :type '(choice (const :tag "Use Fringes" fringes)
> +                 (const :tag "Use Margins "margins)
                                            ^^
A typo there.

> +(defcustom flymake-margin-indicators-string '((error "‼" compilation-error)

This is a non-ASCII character, so we should either use its ASCII
equivalent "!!" or test the display for being able to show it on the
screen (since it is likely the margin indicator will be used on TTY
frames).

Please also accompany your patch with the ChangeLog-style commit log
message (see the file CONTRIBUTE for the details).



  reply	other threads:[~2024-03-13 12:18 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 23:18 [PATCH] Flymake Support Indicator Errors in Margin Elijah G
2024-03-12  9:24 ` Philip Kaludercic
2024-03-12 17:22   ` Elijah G
2024-03-13 12:18     ` Eli Zaretskii [this message]
2024-03-14  1:50       ` Elijah G
2024-03-14 11:05         ` Eli Zaretskii
2024-03-14 11:28           ` João Távora
2024-03-14 15:35           ` Elijah G
2024-03-16 11:10             ` Eli Zaretskii
2024-03-17 16:44               ` bird
2024-03-17 17:01                 ` Eli Zaretskii
2024-03-17 17:34                 ` Elijah G
2024-03-17 18:43                   ` bird
2024-03-17 19:21                     ` Elijah G
2024-03-25  1:46                       ` Elijah G
2024-03-27  0:13                         ` sbaugh
2024-03-27  0:36                           ` Elijah G
2024-03-27 21:29                           ` Elijah G
2024-03-28  6:01                             ` Eli Zaretskii
2024-03-28 17:34                               ` Elijah G
2024-04-06 11:36                                 ` Eli Zaretskii
2024-03-28  7:30                             ` Juri Linkov
2024-03-28 17:44                               ` Elijah G
2024-04-06 11:35                             ` Eli Zaretskii
2024-04-06 20:14                               ` Elijah G
2024-04-07  5:47                                 ` Eli Zaretskii
2024-04-07 17:20                                   ` Elijah G
2024-04-18  9:10                                     ` Eli Zaretskii
2024-03-19  7:03                   ` Augusto Stoffel
2024-03-17 17:49                 ` Elijah G
2024-03-19  7:04                   ` Augusto Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868r2mtjdk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eg642616@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.