all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lin Sun <sunlin7.mail@gmail.com>
Cc: 70271-done@debbugs.gnu.org
Subject: bug#70271: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more
Date: Tue, 09 Apr 2024 06:24:23 +0300	[thread overview]
Message-ID: <868r1nxlp4.fsf@gnu.org> (raw)
In-Reply-To: <CABCREdp_7a-bXceutUhK5=7jft96dybohy5XrAuGHY+44ZaBwg@mail.gmail.com> (message from Lin Sun on Mon, 8 Apr 2024 20:43:54 +0000)

> From: Lin Sun <sunlin7.mail@gmail.com>
> Date: Mon, 8 Apr 2024 20:43:54 +0000
> Cc: 70271@debbugs.gnu.org
> 
> On Mon, Apr 8, 2024 at 11:25 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > > From: Lin Sun <sunlin7.mail@gmail.com>
> > > Date: Mon, 8 Apr 2024 05:10:22 +0000
> > >
> > > The dired ignored the options like "--time=ctime" in the variable
> > > `dired-listing-switches' on Windows OS.
> > >
> > >  I traced the code and found dired will use the functions in the
> > > `ls-lisp.el' instead of calling the real command "/usr/bin/ls", and
> > > the "ls-lisp.el" didn't process the "--time=ctime" option.
> > >
> > > The attached PATCH will convert the "--time=ctime" to "-c"... in the
> > > "ls-lisp.el", and then the dired will display the desired time in its
> > > time column.
> > >
> > > Here is the verification code (on Windows OS), try it one line and
> > > close the dired buffer then try next line.
> > >
> > > (dired "/tmp/aa" "-al --sort=time") ; as "-al -t"
> > >
> > > (dired "/tmp/aa" "-al --time=ctime") ; as "al -c"
> > >
> > > (dired "/tmp/aa" "-al --time=atime") ; as "al -u"
> > >
> > > Please help review the changes and approve them. Thanks
> >
> > Thanks, but how about adding some tests for this?
> 
> Sure, I had added the test case for this ticket.
> 
> Changes are attached in the PATCH.

Thanks, installed on master, and closing the bug.

The test had a small bug, I fixed it.

Also, please look at how I modified the commit log message, and in the
future try following our conventions more closely (capitalization of
log entries, specifying function names, etc.)





  reply	other threads:[~2024-04-09  3:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  5:10 bug#70271: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more Lin Sun
2024-04-08 11:25 ` Eli Zaretskii
2024-04-08 20:43   ` Lin Sun
2024-04-09  3:24     ` Eli Zaretskii [this message]
2024-04-09  4:10       ` Lin Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868r1nxlp4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70271-done@debbugs.gnu.org \
    --cc=sunlin7.mail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.