From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: serg.foo@gmail.com, dancol@dancol.org, 69952@debbugs.gnu.org
Subject: bug#69952: [PATCH] Support pdumping compiled queries by dumping their source
Date: Mon, 22 Apr 2024 09:18:49 +0300 [thread overview]
Message-ID: <868r157wdy.fsf@gnu.org> (raw)
In-Reply-To: <B73B2D3D-98BA-43E2-B8D1-99C9678F1D1A@gmail.com> (message from Yuan Fu on Sun, 21 Apr 2024 23:04:47 -0700)
> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 21 Apr 2024 23:04:47 -0700
> Cc: Daniel Colascione <dancol@dancol.org>,
> serg.foo@gmail.com,
> 69952@debbugs.gnu.org
>
> >> No. You need both tree-sitter library and the grammar library.
> >
> > That's what I thought. So starting Emacs in that case will attempt to
> > call a function from the tree-sitter library, and will segfault,
> > right? If so, we should have some protection in the code in
> > pdumper.c that loads queries, which tests that tree-sitter is
> > availabale, and if not does something to prevent the segfault, like
> > not loading the query, perhaps?
>
> Right, it can use Ftreesit_available_p (we can define a C equivalent if pdumper can’t call lisp), and decide whether to compile the query or just keep the query as a string, or signal an error?
We cannot safely signal an error at that point, I think, so just
keeping the query as a string should do, as it will then signal an
error at run time when that query is used, is that right?
next prev parent reply other threads:[~2024-04-22 6:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 3:27 bug#69952: [PATCH] Support pdumping compiled queries by dumping their source Sergey Vinokurov
2024-03-23 7:08 ` Eli Zaretskii
2024-03-23 12:53 ` Sergey Vinokurov
2024-03-23 13:09 ` Eli Zaretskii
2024-04-13 7:41 ` Eli Zaretskii
2024-04-20 8:08 ` Yuan Fu
2024-04-20 9:32 ` Eli Zaretskii
2024-04-20 22:50 ` Yuan Fu
2024-04-21 4:53 ` Eli Zaretskii
2024-04-21 23:41 ` Yuan Fu
2024-04-22 5:47 ` Eli Zaretskii
2024-04-22 6:04 ` Yuan Fu
2024-04-22 6:18 ` Eli Zaretskii [this message]
2024-04-22 6:25 ` Yuan Fu
2024-05-04 9:39 ` Eli Zaretskii
2024-05-04 21:29 ` Yuan Fu
2024-05-18 8:38 ` Eli Zaretskii
2024-05-22 6:36 ` Yuan Fu
2024-05-22 12:55 ` Eli Zaretskii
2024-05-29 16:35 ` Andrea Corallo
2024-06-01 17:07 ` Yuan Fu
2024-06-15 7:59 ` Eli Zaretskii
2024-06-19 6:25 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868r157wdy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69952@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dancol@dancol.org \
--cc=serg.foo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.