From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69952: [PATCH] Support pdumping compiled queries by dumping their source Date: Sat, 04 May 2024 12:39:05 +0300 Message-ID: <868r0phq6e.fsf@gnu.org> References: <86r0g1zaqi.fsf@gnu.org> <86le5hr9oj.fsf@gnu.org> <861q709y5y.fsf@gnu.org> <9B2A2190-AB42-4F1B-9F9D-5623B343CF0A@gmail.com> <86frvf8gf9.fsf@gnu.org> <86eday6j9o.fsf@gnu.org> <868r157wdy.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9541"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69952@debbugs.gnu.org, dancol@dancol.org To: Yuan Fu , serg.foo@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 04 11:39:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3Bs3-0002Dn-CO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 May 2024 11:39:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3Bru-0007Vt-8B; Sat, 04 May 2024 05:39:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3Bro-0007VM-DD for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 05:39:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3Brn-0002He-Lz for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 05:39:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3BsA-00006t-IL for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 05:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2024 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69952 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69952-submit@debbugs.gnu.org id=B69952.1714815582409 (code B ref 69952); Sat, 04 May 2024 09:40:02 +0000 Original-Received: (at 69952) by debbugs.gnu.org; 4 May 2024 09:39:42 +0000 Original-Received: from localhost ([127.0.0.1]:52393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Brq-00006X-7a for submit@debbugs.gnu.org; Sat, 04 May 2024 05:39:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Brn-00006N-Ht for 69952@debbugs.gnu.org; Sat, 04 May 2024 05:39:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3BrL-0002DR-2Z; Sat, 04 May 2024 05:39:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KPLm3d9KjoUrUwrdlC/26gq7Tvs0N7Pdli4WbNcvP2k=; b=GgNLZzvy4SlY 6DIzoQbE75P2M/P8Akh8h8LW+lKv1fOQVvihAnroe5n/oddROrU9hFWk2/uFPKRaY4rYm/ZmZj2Wa OEtX2+UdG/ePflnXJIWULiqJUIH2vfU9gMkIZ9M+Tf2faLMfNgZTxWaRtQz5f/bdLQuBQrTOT6FY2 lDKTss39ehWb/h134Ch3rTgS/huv8z5J+gh+rxcMYqpHpTh6Iv2tpCxM31OqEl16jRNcAaPHkvwKK eUI9CPamVY1iu8wE8Pw+ORyYfUUmC4BghSxbthDktqXvzYlP7sSRRtbJtNKe/PW+zgcaCmJzLDjCz ZWrsdb86AgEtPFcHiJWpBQ==; In-Reply-To: (message from Yuan Fu on Sun, 21 Apr 2024 23:25:10 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284411 Archived-At: > From: Yuan Fu > Date: Sun, 21 Apr 2024 23:25:10 -0700 > Cc: dancol@dancol.org, > serg.foo@gmail.com, > 69952@debbugs.gnu.org > > > On Apr 21, 2024, at 11:18 PM, Eli Zaretskii wrote: > > > > > > We cannot safely signal an error at that point, I think, so just > > keeping the query as a string should do, as it will then signal an > > error at run time when that query is used, is that right? > > Yes, most likely a function-undefined signal, since all the treesit.c functions like treesit-query-capture or treesit-query-compile will be nonexistent. And usually the Lisp program trying to use the query would check for tree-sitter availability with treesit-available-p before trying to use any tree-sitter functions; so that signal will be usually avoided as well. Can you suggest such an addition to the patch?