all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: rpluim@gmail.com, emacs-devel@gnu.org
Subject: Re: master a739cab6637 2/2: ; * doc/lispref/display.texi (Image Descriptors): Insert missing text.
Date: Thu, 06 Jun 2024 18:08:00 +0300	[thread overview]
Message-ID: <868qzigldb.fsf@gnu.org> (raw)
In-Reply-To: <87v82mfa0z.fsf@yahoo.com> (message from Po Lu on Thu, 06 Jun 2024 21:58:20 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: rpluim@gmail.com,  emacs-devel@gnu.org
> Date: Thu, 06 Jun 2024 21:58:20 +0800
> 
> How's this?
> 
> Alternatively, the symbol @code{default} may be specified, indicating
> that the image should be scaled in one of two ways, selected by the
> value of the @code{image-scaling-factor} variable.  This value is either
> a number providing a constant scale factor, or the default, @code{auto},
> in which case the image will be scaled in proportion to the average
> widths (@pxref{Low-Level Font}) of the default faces of frames on which
> it is displayed and where this default width exceeds @code{10} pixels.
> If no other value is provided, @code{create-image} will specify
> @code{default} in image specifications it creates.

Better, but still "needs work".  Here's my suggestion:

  @var{scale} can also be the symbol @code{default}, which means to
  use the value of @code{image-scaling-factor}.  If that value is a
  number, it is the scale factor to use; if it is @code{auto} (the
  default), it means to compute the scaling factor based on pixel size
  of the font used by the frame's default face (@pxref{Low-Level
  Font}).

And I would like to explain more about "computing the scaling factor
based on pixel size of the font used by the frame's default face", and
what happens if the default font's width is 10 pixels or below, but
your text doesn't really tell that story.  I think it should.  (Btw,
the default width of the font in "emacs -Q" on Windows is 8, so it
will always hit the case which was left unexplained.)

Thanks.



  parent reply	other threads:[~2024-06-06 15:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171740380294.31568.538114951586755322@vcs2.savannah.gnu.org>
     [not found] ` <20240603083643.B2E29C009F4@vcs2.savannah.gnu.org>
2024-06-03 11:27   ` master a739cab6637 2/2: ; * doc/lispref/display.texi (Image Descriptors): Insert missing text Robert Pluim
2024-06-06 12:01     ` Eli Zaretskii
2024-06-06 13:18       ` Po Lu
2024-06-06 13:39         ` Eli Zaretskii
2024-06-06 13:58           ` Po Lu
2024-06-06 14:04             ` Robert Pluim
2024-06-06 15:08             ` Eli Zaretskii [this message]
2024-06-07  0:14               ` Po Lu
2024-06-07  6:29                 ` Eli Zaretskii
2024-06-07  8:50                   ` Po Lu
2024-06-08 13:20                     ` Eli Zaretskii
2024-06-08 13:28                       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868qzigldb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.