From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: luangruo@yahoo.com, 71605@debbugs.gnu.org
Subject: bug#71605: 30.0.50; [PATCH] Support variable-width text in 'visual-wrap-prefix-mode'
Date: Tue, 18 Jun 2024 15:53:13 +0300 [thread overview]
Message-ID: <868qz2quo6.fsf@gnu.org> (raw)
In-Reply-To: <f6f70ad9-ae35-7f00-5888-1c0d69bf84b0@gmail.com> (message from Jim Porter on Mon, 17 Jun 2024 23:27:49 -0700)
> Date: Mon, 17 Jun 2024 23:27:49 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: luangruo@yahoo.com, 71605@debbugs.gnu.org
>
> On 6/17/2024 8:02 PM, Jim Porter wrote:
> > Just so others are aware I'm going to try and bisect this. I'll report
> > back when it's finished.
>
> Looks like this is the commit that regressed this:
>
>
> commit fb3d582e7ba595b7680e2c2adf22c7ab699e5792
> Author: Eli Zaretskii <eliz@gnu.org>
> Date: Wed Jun 29 20:15:36 2022 +0300
>
> Fix hscrolling of :align-to when display-line-numbers is in effect
>
> * src/dispextern.h (struct it): Rename 'tab_offset' member to
> 'stretch_adjust'.
> * src/xdisp.c (gui_produce_glyphs, produce_stretch_glyph)
> (display_line): All users of 'tab_offset' changed.
> (produce_stretch_glyph): Fix calculation of ':align-to' when
> line numbers are displayed and the window is hscrolled.
> (calc_pixel_width_or_height): Fix calculation of width of 'space'
> display property when 'display-line-numbers' is turned on, but the
> line number was not yet produced for the current glyph row.
> (Bug#56176)
Thanks.
Unfortunately, it means the current behavior is not a bug, but rather
an unintended consequence of another bugfix. The above changeset
changed :align-to to count from the beginning of the physical line,
not the screen line. So, for example, if you have an 80-column line,
the continuation line begins from column 80, not 0. Thus, something
like ':align-to 4' will never work on continuation lines, because we
got past column 4 long ago...
So I need to think whether and how to restore the capability of using
:align-to in wrap-prefix.
next prev parent reply other threads:[~2024-06-18 12:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 2:56 bug#71605: 30.0.50; [PATCH] Support variable-width text in 'visual-wrap-prefix-mode' Jim Porter
2024-06-17 11:37 ` Eli Zaretskii
2024-06-17 17:42 ` Jim Porter
2024-06-17 18:20 ` Eli Zaretskii
2024-06-17 18:44 ` Jim Porter
2024-06-18 11:37 ` Eli Zaretskii
2024-06-18 22:17 ` Jim Porter
2024-06-19 11:45 ` Eli Zaretskii
2024-06-19 19:53 ` Jim Porter
2024-06-20 4:58 ` Eli Zaretskii
2024-06-20 5:37 ` Jim Porter
2024-06-20 9:58 ` Eli Zaretskii
2024-06-20 17:36 ` Jim Porter
2024-06-20 18:08 ` Eli Zaretskii
2024-06-20 19:01 ` Jim Porter
2024-07-28 4:53 ` Jim Porter
2024-08-02 7:27 ` Eli Zaretskii
2024-08-04 19:24 ` Jim Porter
2024-06-17 14:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 16:13 ` Jim Porter
2024-06-17 18:17 ` Jim Porter
2024-06-17 19:55 ` Eli Zaretskii
2024-06-17 20:08 ` Jim Porter
2024-06-18 3:02 ` Jim Porter
2024-06-18 6:27 ` Jim Porter
2024-06-18 12:53 ` Eli Zaretskii [this message]
2024-06-18 12:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868qz2quo6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71605@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.