From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master fa4203300fd: Merge remote-tracking branch 'origin/feature/which-key-in-core' Date: Wed, 19 Jun 2024 16:10:23 +0300 Message-ID: <868qz1oz7k.fsf@gnu.org> References: <171873998859.23986.6867742580209068033@vcs2.savannah.gnu.org> <20240618194635.AC606C1FB66@vcs2.savannah.gnu.org> <8734p9z9d0.fsf@gmail.com> <878qz1l6p3.fsf@posteo.net> <87y171xqoq.fsf@gmail.com> <87tthpxhto.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12040"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 19 15:11:19 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJv5r-0002oO-8s for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Jun 2024 15:11:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJv55-0005Qb-HA; Wed, 19 Jun 2024 09:10:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJv53-0005Pr-M1 for emacs-devel@gnu.org; Wed, 19 Jun 2024 09:10:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJv51-0003vf-BH; Wed, 19 Jun 2024 09:10:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=OnOgsPPrB0yNvKxjd3r4WxlyGvRfiWONFFafhVN/GSU=; b=NAagrIFSjKSQWh/Bd72L tG7dLXZ3OMV7cMKeZd/8NdqF+SvJ3YTtUva/3jv7jWKAmfzlr3cr7KfI2u2bcTBVHRaYjdNHUqG2v B6iUunEADGLJ8A2mgqC9p0GyIPxwrYF+1PHWR3MEYy4hpaOO6knCJtlcb07AJmV1D3agBC/L6Zguy iWWKQyRIUIlNqPyTGOhPYyE0idedTtbx0JgEDEfsU5vdwBtK4MmbfPzFu523fknLNo03NK8BCRfDW 7n4jB9JkuPPTSp5qxpNuxB85E2iTQ8yGTiNtp/BSjToMpaVY5nuWUs8jqaL8ZdHAe07AmwqpFj1ad TMVDpzFy9KJRgQ==; In-Reply-To: <87tthpxhto.fsf@gmail.com> (message from Robert Pluim on Wed, 19 Jun 2024 14:01:07 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320293 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Wed, 19 Jun 2024 14:01:07 +0200 > > >>>>> On Wed, 19 Jun 2024 10:49:41 +0200, Robert Pluim said: > > >>>>> On Wed, 19 Jun 2024 07:42:16 +0000, Philip Kaludercic said: > Philip> Robert Pluim writes: > >>>>>>>> On Tue, 18 Jun 2024 15:46:35 -0400 (EDT), Philip Kaludercic said: > >>> > Philip> + > Philip> ++++ > Philip> +** New package Which-Key > Philip> +The 'which-key' package from GNU ELPA is now included in Emacs. It > Philip> +implements the 'which-key-mode' that displays a table of key bindings > Philip> +upon entering a partial key chord and waiting for a moment. > Philip> + > >>> > >>> This doesnʼt appear to work for the "iso-transl" key bindings, but > >>> then again Iʼm not sure it should :-) > > Philip> I am not sure what bindings you have in mind specifically. While I > Philip> don't really have a good, global understanding of which-key, I can try > Philip> to look into the issue (if it is one), if you give me something to test. > > Robert> Iʼm thinking of stuff like 'C-x 8 * E'. Itʼs possible to argue that > Robert> doesnʼt qualify as a 'key binding', since its entire purpose is to > Robert> enter a specific character, not run a command. > > This patch does it, now we just need to decide if we want to do it, > and if so, should there be a user option to enable it? Perhaps > `function-key-map' should not be consulted. What's the downside of doing this unconditionally? > are we planning to turn `which-key-mode' on by default? Not in Emacs 30, no.