From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Sun, 30 Jun 2024 15:49:40 +0300 Message-ID: <868qymh9y3.fsf@gnu.org> References: <87v81u85hv.fsf@localhost> <87frsx81m2.fsf@localhost> <87cyo180y2.fsf@localhost> <874j9d7zqe.fsf@localhost> <87sewvg6lw.fsf@localhost> <87sewuk4l6.fsf@localhost> <87r0celi67.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30647"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org, eller.helmut@gmail.com To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 30 14:50:04 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNu0J-0007iG-JQ for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jun 2024 14:50:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNu03-0006vu-MZ; Sun, 30 Jun 2024 08:49:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNu01-0006vc-2w for emacs-devel@gnu.org; Sun, 30 Jun 2024 08:49:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNu00-0000Qk-KO; Sun, 30 Jun 2024 08:49:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=EebdwUL60vJC61Ma0iNUH0hMk/LsW4VBaASttnkpB2w=; b=Tuxn2JAaz/IZl5A9CIoF d1x2XZjM4A6RzsmZhXuwaX8rNowmz4CBq7i2IE5iKu6dKevVz4ja8fHFiFHgn+Iof2M0T52Kjuj17 pcOh7zvl7Jk1a4PBJP6C724EtiFS2uv4RpNyEKCa+rQTMQnqtprQMjFVEmo5SMrjarkpW1doE0os+ gXQcWq7W3QM5ZY59fwsvBm8IbYkEgSCG7p96mbqBQcXpTYkNxY47sTU0x5UMdFGEMD8zDDHqv7sNq Kdw97iLk32L12PufEMmg7D+FgYEPegP9dByOA6TovbiqpFdhFUqD31BdkhSxHIzHPC+5CzHaoA6L/ 4bmN+x8QB5kV2Q==; In-Reply-To: <87r0celi67.fsf@localhost> (message from Ihor Radchenko on Sun, 30 Jun 2024 12:38:24 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320963 Archived-At: > From: Ihor Radchenko > Cc: Stefan Monnier , emacs-devel@gnu.org, Eli > Zaretskii , eller.helmut@gmail.com > Date: Sun, 30 Jun 2024 12:38:24 +0000 > > Gerd Möllmann writes: > > > Thanks, Ihor, that looks promising. I've now also pushed a quick and > > dirty add_marker in O(1), that's why I reverted. to get that on top. > > Works for me... > > > > A comparison of how it feels compared to master would also be interesting. > > igc.c: In function ‘fix_marker_vector’: > igc.c:1701:34: error: passing argument 1 of ‘NILP’ makes pointer from integer without a cast [-Wint-conversion] > 1701 | if (NILP (v->contents[i] && !NILP (old))) > | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ > | | > | int > In file included from igc.c:31: > lisp.h:1499:21: note: expected ‘Lisp_Object’ {aka ‘struct Lisp_X *’} but argument is of type ‘int’ > 1499 | (NILP) (Lisp_Object x) > | ~~~~~~~~~~~~^ I think I fixed that.