From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72229: (setq overriding-terminal-local-map nil) in isearch-done Date: Tue, 23 Jul 2024 14:29:25 +0300 Message-ID: <868qxs9wiy.fsf@gnu.org> References: <87r0bmer66.fsf@web.de> <87sew17fs1.fsf@web.de> <864j8gsk4i.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12974"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 72229@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 23 13:31:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWDjm-0003CE-HE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jul 2024 13:31:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWDjZ-0004ZI-Ce; Tue, 23 Jul 2024 07:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWDjN-0004J2-Qg for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 07:30:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWDjN-0001mZ-FG for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 07:30:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWDjR-0003iV-NS for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 07:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2024 11:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72229 X-GNU-PR-Package: emacs Original-Received: via spool by 72229-submit@debbugs.gnu.org id=B72229.17217342177533 (code B ref 72229); Tue, 23 Jul 2024 11:31:01 +0000 Original-Received: (at 72229) by debbugs.gnu.org; 23 Jul 2024 11:30:17 +0000 Original-Received: from localhost ([127.0.0.1]:59359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWDii-0001ws-Sa for submit@debbugs.gnu.org; Tue, 23 Jul 2024 07:30:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWDih-0001a6-Gk for 72229@debbugs.gnu.org; Tue, 23 Jul 2024 07:30:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWDiW-0001UF-M3; Tue, 23 Jul 2024 07:30:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jWFEEFWsL/BglGZAMT78RrSX3axabfTBpDTs/ldKSVg=; b=gOHsEOzWRIzm 5r2oHUYT6nvpg1Uzh/DOs2KZittsUk2baxLl1MG17yXqORk0/EG1Z8o3aueU8dZbxS2+BWPFghRNk kuMggvd4Jw/q1KAKyqLzzx4bk+bYaA1EfrKYleGrA3U8koSQHWfL2B/1AmEa1cv49Yhm45TIYtVnr vYi0EW8jJZg4pdOxhOLOcwC9cWhz1qDEYiow4rdY2ikZp/q9vjzvMkTIhCvPX4BVV1x6XRNIB45S6 hxVTQK1JCDWUcsPHqKER8/5Vh8aZHrWDGAFFVo/I5X7jW01UE7rymWN2cLhRuGRpnKhpQiE/46p2T YoVIzOywWDYXrwm6p8hGEQ==; In-Reply-To: <864j8gsk4i.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 23 Jul 2024 09:32:21 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289158 Archived-At: > Cc: 72229@debbugs.gnu.org > From: Juri Linkov > Date: Tue, 23 Jul 2024 09:32:21 +0300 > > > Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife > > of text editors" writes: > > > >> exiting isearch always explicitly sets `overriding-terminal-local-map' > >> to nil. This will interfere with any other users of > >> `overriding-terminal-local-map', including any active transient maps. > >> > >> Wouldn't a less radical means suffice? If isearch really must _set_, > >> i.e., completely override that variable, why not restore the original > >> value? > > > > Juri, what's your opinion on this? > > Indeed, you are right, `isearch-done' should restore the original value. > The existing variable `isearch--saved-overriding-local-map' can't be used, > so a similar variable should be added like in this patch: Thanks. If this is deemed the right solution, please install on master, not on emacs-30 (as we have lived with this issue since 1995).