From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72272: [PATCH] dired-hide-details-mode hides directory's absolute path Date: Sat, 17 Aug 2024 11:53:36 +0300 Message-ID: <868qwv4jjj.fsf@gnu.org> References: <86plqosoem.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2946"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72272@debbugs.gnu.org, acorallo@gnu.org To: Alvaro Ramirez Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 17 10:54:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfFCl-0000dz-A0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Aug 2024 10:54:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfFCd-0000qY-38; Sat, 17 Aug 2024 04:54:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfFCZ-0000q2-NM for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 04:54:23 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfFCZ-0008Hx-8u for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 04:54:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=Y/7FRRMRPYUtId9AGlqSqC0ZPmmJfXlzlHRuzkuGEtE=; b=W5e8czVVtXLn2sRQKZ6r0TNCn11mN9/E2PKzqxOPq6VJErKIIMLoPvaO3KbE/ejieueTZ/eJrnfoLgE99TjPzRskHYLkHmOdtCw3vAO3GC96sncsa8ESXYzIqgOJNBYlpQYFV0m3BoLrVO/W8nfDLN4K9JuVF9Qu3A/y87siVJZX7ysE+JcoZfm60FrymWMEPv5Kffo2oOqNQNQOE7tTXMbKNLH1W00d+KggZd3XHeDfEekTBgClgKDzE/ZNPBlraFmz21+GdVOrsOpW8rkIGzHrRPNSlPbWKgDoSB70gcXCAH08DH60N54Wmq9Ib/qr61+OWz27BPxVqQSUs4KUBg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfFDB-0001ZO-Sv for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 04:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2024 08:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72272-submit@debbugs.gnu.org id=B72272.17238848665986 (code B ref 72272); Sat, 17 Aug 2024 08:55:01 +0000 Original-Received: (at 72272) by debbugs.gnu.org; 17 Aug 2024 08:54:26 +0000 Original-Received: from localhost ([127.0.0.1]:53466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFCc-0001YU-7f for submit@debbugs.gnu.org; Sat, 17 Aug 2024 04:54:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFCZ-0001YC-Kf for 72272@debbugs.gnu.org; Sat, 17 Aug 2024 04:54:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfFBr-00085U-GP; Sat, 17 Aug 2024 04:53:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Y/7FRRMRPYUtId9AGlqSqC0ZPmmJfXlzlHRuzkuGEtE=; b=eqpBCXIAiunc msodc1MYe8DvVk1fS3Eic2GN6rTxj3TMQIXyd4/3p+p/XE0Fvm+mNYOPPVgdw6BiDNzlbr9rGLsJC MXh0v8Yh0XJVnenaoxJmbD6w0JFJqosPAa6csc8szz31IYZYv4Ebos+NkCocxgwCcYVfCbCAQepsk 2nVo5rHfw3I95txsNwPrh0gyahcQo1V1fY36O/0Mp8OZ1hZU5MrxEky0nwkG7fIxabSoZ55pTqg3Q 8vxYZKSRO0psnXbr/kW/hOSky8O/KC24rMN56oyUwhB8JpKGGZozkEzaCGQVV8k5z4UeM9j0fJ8j9 IrrfYqZPH/zsRsSs2/6kHw==; In-Reply-To: (message from Alvaro Ramirez on Mon, 05 Aug 2024 15:34:17 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290239 Archived-At: > From: Alvaro Ramirez > Cc: eliz@gnu.org, 72272@debbugs.gnu.org > Date: Mon, 05 Aug 2024 15:34:17 +0100 > > I also modified the patch a little to cater for > `dired-maybe-insert-subdir` (see > https://lists.gnu.org/archive/html/emacs-devel/2024-08/msg00033.html) > and to include a couple of tests. > > May be worth noting, the following dired.el comment seemed > outdated > https://github.com/emacs-mirror/emacs/blob/c7d9cd722e5a7042a52c92f8497f903bfe9870b8/lisp/dired.el#L1805 > > ;; Note that dired-build-subdir-alist will replace the name > ;; by its expansion, so it does not matter whether what we insert > ;; here is fully expanded, but it should be absolute. > > The mentioned replacement doesn't take place when using > `dired-maybe-insert-subdir`, so I tweaked the comment. Setting > invisible property is now needed in two places (to handle current > location and now subdirs). > > Please take a look at the latest patch. Happy to go with a > different direction if preferred. Thanks, this LGTM. However, AFAIU your copyright-assignment paperwork is not yet completed, so we should wait for that, and then we can install.