From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: rudalics@gmx.at, 73734@debbugs.gnu.org
Subject: bug#73734: [PATCH] Fix tmm menu layout
Date: Thu, 10 Oct 2024 21:29:48 +0300 [thread overview]
Message-ID: <868quv24mb.fsf@gnu.org> (raw)
In-Reply-To: <878quv96sk.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 10 Oct 2024 20:00:59 +0200)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: martin rudalics <rudalics@gmx.at>, 73734@debbugs.gnu.org
> Date: Thu, 10 Oct 2024 20:00:59 +0200
>
> > What is the "selection character" in this image?
>
> On the image below, "n" is what I called the selection character for
> "Next Marked" while "* c" is the keybinding for "Change Marks...". The
> proximity of those two makes this hard to read IMO.
Ah, I see now what you meant. But if this is the problem, then
changing the column width is not a reliable solution, because you
cannot know in advance what will be the width of the SPC glyph in a
font people use. I suggest to use 'display' properties instead, for
example '(space . (:width N)), where N is the number of canonical
columns we want the space to take on display.
> >> This patch tries to solves this issue.
> >
> > Can you tell how? All I see is a different value for colwidth. I
> > guess I'm missing something.
>
> Yes but this different colwidth would leave more space between a
> keybinding and the "selection character" of the next column. But, I
> have to say that it would be hard to prove that it will work for every
> possible settings.
Yes, I think using the 'display' property will be more reliable.
> >> Here, how I justify the modification of `colwidth':
> >>
> >> - I don't think we need the "(min 30)" part since, if the frame is
> >> wide enough, we always get a colwidth of 30.
> >>
> >> - I don't think "(window-width)" is what we need since, by
> >> default, the *Completions* buffer will use the full frame width.
> >
> > Martin, is that guaranteed?
> >
> > And even if it is, what's the harm in keeping window-width?
>
> I don't think that a full frame width *Completions* buffer is
> guaranteed: it is only what I see with "emacs -Q".
>
> Keeping window-width in this calculation seems a bit strange because, by
> default, it has nothing to do with the *Completions* buffer window
> width.
Which window's width does this return in this case?
next prev parent reply other threads:[~2024-10-10 18:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 13:53 bug#73734: [PATCH] Fix tmm menu layout Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 16:14 ` Eli Zaretskii
2024-10-10 18:00 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 18:29 ` Eli Zaretskii [this message]
2024-10-11 6:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 6:51 ` Eli Zaretskii
2024-10-11 7:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 8:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 9:26 ` Eli Zaretskii
2024-10-11 10:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 16:44 ` Eli Zaretskii
2024-10-12 14:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 14:44 ` Eli Zaretskii
2024-10-12 15:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 16:26 ` Eli Zaretskii
2024-10-12 16:40 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 8:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 9:46 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 12:21 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 7:29 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 7:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 8:15 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 9:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868quv24mb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73734@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.