From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Sun, 20 Oct 2024 11:20:19 +0300 Message-ID: <868qujjid8.fsf@gnu.org> References: <87pm5yo4m7.fsf@gmail.com> <87legmnq4l.fsf@gmail.com> <87r090o8cl.fsf@melete.silentflame.com> <874j5vgypf.fsf@melete.silentflame.com> <787fb692-db24-4682-871b-5a52d31a1249@gutov.dev> <87ed4obs1b.fsf@melete.silentflame.com> <87o73sad24.fsf@melete.silentflame.com> <877ca63ln5.fsf@melete.silentflame.com> <86r08enfri.fsf@gnu.org> <87cyjyvsns.fsf@melete.silentflame.com> <868qulojrx.fsf@gnu.org> <87zfn1vjvb.fsf@melete.silentflame.com> <864j59ob91.fsf@gnu.org> <87ldyjvbgz.fsf@melete.silentflame.com> <86h697jrpu.fsf@gnu.org> <87plnvtk88.fsf@melete.silentflame.com> <86bjzfjofn.fsf@gnu.org> <87zfmzs0mp.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16318"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan.J.Smith@outlook.com, rpluim@gmail.com, 64055@debbugs.gnu.org, dmitry@gutov.dev To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 20 10:20:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2RBK-00044d-Vu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Oct 2024 10:20:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2RB2-0001Qy-Gz; Sun, 20 Oct 2024 04:20:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2RAz-0001QY-FT for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:20:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2RAz-0006to-7J for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:20:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=p2W0+bu7JZlsw0I8ItbSK17o9AuR2KxzVwqzkSCPX+0=; b=lIk6o8kTD4A5S3LrtOm8FA35wniSWVAWpv3gOJmo8cmZxXQlR4bsmHzpBrFMZSE9KUP6I/1VrXw6ABNmijMr1TBm1MpRK/lgHSTTZF3ft01IoKOpZmyTggBmwHQ+pZv46q4fLuZ5L+D3B7bWh+ig2hlDdrU6WR98iU+QXiYgvIMKgSL9//j2vlctMB+p/zcVMboEB6v9GAvCRLGV/dsltEnZaJUk/ieHRDb+Yrdkgvg0Xa+i8Jr1iXw2jKQYYgCwZIJsswK5VSgueIK+0iN+4iAJP2dOhDW79kCl9o04CWAjenwWu36D/YRtlj0h0AneO8+DykC2+L7jkP7o1BJA6Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2RBN-0001tx-N2 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 04:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 08:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.17294124577292 (code B ref 64055); Sun, 20 Oct 2024 08:21:01 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 20 Oct 2024 08:20:57 +0000 Original-Received: from localhost ([127.0.0.1]:45648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2RBI-0001tY-Mv for submit@debbugs.gnu.org; Sun, 20 Oct 2024 04:20:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2RBF-0001tJ-B6 for 64055@debbugs.gnu.org; Sun, 20 Oct 2024 04:20:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2RAk-0006sR-Kp; Sun, 20 Oct 2024 04:20:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=p2W0+bu7JZlsw0I8ItbSK17o9AuR2KxzVwqzkSCPX+0=; b=SQrhXlglrd1T O+1zvvgXZz66SsCy+OYitWLN/865XeCM2hYx/xjZ2rZFVApHoCqOMVg2yfy0zQ0y3NUpFQJSCtsC6 TI4w0xdk6kK4+3nChc4K/EbKWW7wvziAZxWGCaeFUIqdN+1T4Rgt7GxxuD/WuMReCqPk9JI3gSwCO mpU8Rf73HA4P/Z9J6M0F14XCIcJAkDbQsnxIkGIbkYS0OBJRJzPSM58kYqRkZ/vbqwsZA/e84vQLS skvvEsJEkGx/7glljCbwApWcLMhb0SKAQ2QFgWnlKcjcuuHvZrWqKucUJyHgfKFC5c80lNaN7+n4N RXUDnn+gkfPwJ8Ua45sfHw==; In-Reply-To: <87zfmzs0mp.fsf@melete.silentflame.com> (message from Sean Whitton on Sun, 20 Oct 2024 15:18:38 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293933 Archived-At: > From: Sean Whitton > Cc: 64055@debbugs.gnu.org, Morgan.J.Smith@outlook.com, rpluim@gmail.com, > dmitry@gutov.dev > Date: Sun, 20 Oct 2024 15:18:38 +0800 > > Hello, > > On Sun 20 Oct 2024 at 09:09am +03, Eli Zaretskii wrote: > > > I see vc-hg-log-switches and vc-bzr-log-switches, so I don't think I > > understand why you say Git is special here. What did I miss? > > By "older VCS" I did not mean to include Hg and bzr, which are special > in the same way as Git. And indeed, neither vc-bzr or vc-hg have > log-view-modify-change-comment support. It would be good to add it. I consider this change incomplete until we add that support at least for Hg. > > In any case, the reason for having a backend method should be > > explained in the comments. > > I've added a FIXME pointing to this bug. Is there somewhere else you > have in mind? I don't see it; did you forget to push? In any case, I prefer an explicit explanation, including the reference to the vc-*-log-switches variables, not just a reference to a bug number. Thanks.