From: "Jan Djärv" <jan.h.d@swipnet.se>
To: martin rudalics <rudalics@gmx.at>
Cc: "esabof@gmail.com" <esabof@gmail.com>,
"14233@debbugs.gnu.org" <14233@debbugs.gnu.org>
Subject: bug#14233: 24.3; Don't constrain frame size to character multiples
Date: Tue, 23 Apr 2013 13:58:07 +0200 [thread overview]
Message-ID: <868917EF-7586-4F0D-BCDA-0B6F83FBB0A6@swipnet.se> (raw)
In-Reply-To: <5175679B.8010903@gmx.at>
Hello.
22 apr 2013 kl. 18:38 skrev martin rudalics <rudalics@gmx.at>:
> >>> This is insane. it means changing lots and lots of calls, and makes merging between branches harder.
> >> Currently, change_frame_size doesn't know anything about the various
> >> platforms' requirements going beyond those of the frame's text area.
> >
> > I don't understand what you are trying to say.
>
> change_frame_size has no idea whether it is called for a text or a
> graphical frame. Text frames might want to call it as before using
> character sizes. Callers that are able to process pixels and want them
> applied will call it with pixel sizes. In any case, the callers have to
> strip space used for tool- or menubars because change_frame_size does
> not know whether these are part of the frame or not.
We do have macros like FRAME_MENUBAR_HEIGHT and FRAME_TOOLBAR_HEIGHT that can be used. It is better to have that calculation in one place, rather than in each port, so this might be a good time to move it.
>
> >>> Make a new function (change_frame_size_pixelwise for example), with the arguments above, and let change_frame_size call it with the last argument false.
> >> And how would change_frame_size know what the new pixel dimensions of
> >> the frame's text area are?
> >
> > As Emacs has always done, multiply by canonical character pixel size.
>
> Doing that would just leave things as they are now.
>
> When I maximize a frame, that frame may get a new pixel size which is
> not necessarily a multiple of the frame's character size. If I now want
> to resize that frame's windows (and not leave some spare pixels at the
> bottom of the frame as we do now) I have to communicate the new pixel
> size of the frame's root window to the window resizing mechanism. The
> function that does that is change_frame_size.
That is one occasion where a pixel-function is needed. But for most calls, pixel precision is not needed. These are the non-tile/fullscreen/maxmimized cases in X and NS.
Jan D.
next prev parent reply other threads:[~2013-04-23 11:58 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 23:58 bug#14233: 24.3; Don't constrain frame size to character multiples E Sabof
2013-04-20 0:17 ` Glenn Morris
2013-04-20 6:45 ` Eli Zaretskii
2013-04-20 8:53 ` martin rudalics
2013-04-20 9:11 ` Jan Djärv
2013-04-20 11:00 ` martin rudalics
2013-04-20 12:56 ` Jan Djärv
2013-04-20 13:13 ` Eli Zaretskii
2013-04-20 19:26 ` Jan Djärv
2013-04-20 19:54 ` Eli Zaretskii
2013-04-20 22:02 ` Drew Adams
2013-04-21 3:40 ` Stefan Monnier
2013-04-21 7:04 ` Jan Djärv
2013-04-21 9:28 ` martin rudalics
2013-04-21 17:05 ` Jan Djärv
2013-04-22 9:34 ` martin rudalics
2013-04-22 14:17 ` Stefan Monnier
2013-04-21 9:27 ` martin rudalics
2013-04-21 9:27 ` martin rudalics
2013-04-20 20:47 ` E Sabof
2013-04-21 9:26 ` martin rudalics
2013-04-21 17:21 ` Jan Djärv
2013-04-22 9:34 ` martin rudalics
2013-04-22 13:11 ` Jan Djärv
2013-04-22 15:36 ` martin rudalics
2013-04-22 16:11 ` Jan Djärv
2013-04-22 16:38 ` martin rudalics
2013-04-22 18:21 ` Eli Zaretskii
2013-04-23 6:52 ` martin rudalics
2013-04-23 16:28 ` Eli Zaretskii
2013-04-24 6:39 ` martin rudalics
2013-04-24 17:13 ` Eli Zaretskii
2013-04-23 11:58 ` Jan Djärv [this message]
2013-04-23 12:33 ` martin rudalics
2013-04-23 16:48 ` Eli Zaretskii
2013-04-24 6:39 ` martin rudalics
2013-04-24 16:54 ` Jan Djärv
2013-04-25 7:29 ` martin rudalics
2013-04-25 9:55 ` Jan Djärv
2013-04-25 11:58 ` martin rudalics
2013-04-25 15:47 ` Richard Stallman
2013-04-24 17:15 ` Eli Zaretskii
2013-04-24 17:50 ` Jan Djärv
2013-04-25 7:29 ` martin rudalics
2013-04-20 13:38 ` martin rudalics
2013-04-20 19:33 ` Jan Djärv
2013-04-20 16:22 ` Drew Adams
2013-04-20 17:12 ` Eli Zaretskii
2013-04-20 21:50 ` Drew Adams
2013-04-21 9:27 ` martin rudalics
2013-04-21 16:17 ` Drew Adams
2013-04-20 9:25 ` Eli Zaretskii
2013-04-20 11:01 ` martin rudalics
2013-04-20 11:32 ` Eli Zaretskii
2013-04-20 13:38 ` martin rudalics
2013-04-20 16:25 ` Eli Zaretskii
2013-04-20 17:35 ` martin rudalics
2013-04-20 17:48 ` E Sabof
2013-04-20 18:26 ` Eli Zaretskii
2013-04-21 9:26 ` martin rudalics
2013-04-21 15:03 ` Eli Zaretskii
2013-04-22 9:34 ` martin rudalics
2013-04-21 17:30 ` Jan Djärv
2013-04-22 9:34 ` martin rudalics
2013-04-22 13:12 ` Jan Djärv
2013-04-22 15:36 ` martin rudalics
2013-04-22 18:36 ` Eli Zaretskii
2013-04-23 6:54 ` martin rudalics
2013-04-23 16:29 ` Eli Zaretskii
2013-04-23 6:50 ` martin rudalics
2013-04-23 16:23 ` Eli Zaretskii
2013-04-24 6:38 ` martin rudalics
2013-04-24 17:09 ` Eli Zaretskii
2013-04-24 18:50 ` Stefan Monnier
2013-04-24 20:09 ` Jan Djärv
2013-04-25 7:31 ` martin rudalics
2013-04-25 10:02 ` Jan Djärv
2013-04-25 11:58 ` martin rudalics
2013-04-25 14:11 ` Jan Djärv
2013-04-25 7:30 ` martin rudalics
2013-04-25 7:29 ` martin rudalics
2013-04-25 16:24 ` Eli Zaretskii
2013-04-26 7:42 ` martin rudalics
2013-04-26 13:21 ` Stefan Monnier
2013-04-26 14:39 ` Drew Adams
2013-04-27 6:59 ` martin rudalics
2013-04-27 13:53 ` Drew Adams
2013-04-28 12:17 ` martin rudalics
2013-04-28 15:33 ` Drew Adams
2013-04-28 16:29 ` Drew Adams
2013-04-29 7:33 ` martin rudalics
2013-04-29 14:10 ` Drew Adams
2013-04-29 16:48 ` martin rudalics
2013-04-29 20:41 ` Drew Adams
2013-04-30 7:34 ` martin rudalics
2013-04-30 15:47 ` Drew Adams
2013-04-30 17:08 ` martin rudalics
2013-04-30 19:45 ` Drew Adams
2013-05-01 9:15 ` martin rudalics
2013-05-01 13:47 ` Drew Adams
2013-05-02 9:22 ` martin rudalics
2013-05-02 13:28 ` Drew Adams
2014-12-25 19:30 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868917EF-7586-4F0D-BCDA-0B6F83FBB0A6@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=14233@debbugs.gnu.org \
--cc=esabof@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.