From: Tetsurou Okazaki <okazaki@be.to>
To: 5720@debbugs.gnu.org
Cc: okazaki@be.to
Subject: bug#5720: 24.0.50; make uninstall removes some files under lib-src if $(DESTDIR)${archlibdir} is not exist
Date: Mon, 15 Mar 2010 13:40:12 +0900 [thread overview]
Message-ID: <867hperydv.wl%%cc9230e4f6b11649d75e8c3813911dbe1dd37419@be.to> (raw)
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
Running `make uninstall' deletes some script files under lib-src
when a corresponding $(DESTDIR)${archlibdir} is not exist, since
the uninstall rule does not check the status of `cd $(DESTDIR)${archlibdir}'.
To reproduce this condition:
extract or check out the emacs source tree at the machine Emacs is not installed
or
update the source tree until `emacs-version' is updated to the one not installed yet
then
% ./configure
% make uninstall
Please apply the attached patch to fix this.
It also avoids `make uninstall' stops when `cd $(DESTDIR)${archlibdir}' fails.
[-- Attachment #2: emacs-uninstall-fix.diff --]
[-- Type: application/octet-stream, Size: 1510 bytes --]
=== modified file 'Makefile.in'
*** Makefile.in 2010-01-13 08:35:10 +0000
--- Makefile.in 2010-03-01 11:33:10 +0000
***************
*** 667,673 ****
esac ; \
fi ; \
done
! (cd $(DESTDIR)${archlibdir} && rm -f fns-*)
-rm -rf $(DESTDIR)${libexecdir}/emacs/${version}
(cd $(DESTDIR)${infodir} && \
for elt in $(INFO_FILES); do \
--- 667,675 ----
esac ; \
fi ; \
done
! if [ -d $(DESTDOR)${archlibdir} ]; then \
! (cd $(DESTDIR)${archlibdir} && rm -f fns-*) \
! fi
-rm -rf $(DESTDIR)${libexecdir}/emacs/${version}
(cd $(DESTDIR)${infodir} && \
for elt in $(INFO_FILES); do \
=== modified file 'lib-src/Makefile.in'
*** lib-src/Makefile.in 2010-01-13 08:35:10 +0000
--- lib-src/Makefile.in 2010-03-10 22:44:29 +0000
***************
*** 338,345 ****
for file in ${INSTALLABLES} ${INSTALLABLE_SCRIPTS}; do \
rm -f $(DESTDIR)${bindir}/`echo $${file} | sed '$(TRANSFORM)'` ; \
done)
! (cd $(DESTDIR)${archlibdir}; \
! rm -f ${UTILITIES} ${INSTALLABLES} ${SCRIPTS} ${INSTALLABLE_SCRIPTS})
mostlyclean:
-rm -f core *.o getopt.h getopt.h-t
--- 338,347 ----
for file in ${INSTALLABLES} ${INSTALLABLE_SCRIPTS}; do \
rm -f $(DESTDIR)${bindir}/`echo $${file} | sed '$(TRANSFORM)'` ; \
done)
! if [ -d $(DESTDIR)${archlibdir} ]; then \
! (cd $(DESTDIR)${archlibdir} && \
! rm -f ${UTILITIES} ${INSTALLABLES} ${SCRIPTS} ${INSTALLABLE_SCRIPTS}) \
! fi
mostlyclean:
-rm -f core *.o getopt.h getopt.h-t
next reply other threads:[~2010-03-15 4:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 4:40 Tetsurou Okazaki [this message]
2010-03-18 5:19 ` bug#5720: 24.0.50; make uninstall removes some files under lib-src if $(DESTDIR)${archlibdir} is not exist Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867hperydv.wl%%cc9230e4f6b11649d75e8c3813911dbe1dd37419@be.to \
--to=okazaki@be.to \
--cc=5720@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.